diff --git a/.changeset/nine-peaches-notice.md b/.changeset/nine-peaches-notice.md new file mode 100644 index 0000000000..3ad0384d4c --- /dev/null +++ b/.changeset/nine-peaches-notice.md @@ -0,0 +1,5 @@ +--- +"@sumup-oss/circuit-ui": patch +--- + +Centralized the "Close" label translations in CloseButton component and made the label optional in components that require it. diff --git a/packages/circuit-ui/components/AutocompleteInput/components/ComboboxInput/ComboboxInput.tsx b/packages/circuit-ui/components/AutocompleteInput/components/ComboboxInput/ComboboxInput.tsx index 04bf861f3b..33fcf93f75 100644 --- a/packages/circuit-ui/components/AutocompleteInput/components/ComboboxInput/ComboboxInput.tsx +++ b/packages/circuit-ui/components/AutocompleteInput/components/ComboboxInput/ComboboxInput.tsx @@ -199,7 +199,7 @@ export const ComboboxInput = forwardRef( readOnly={readOnly} {...props} /> - {value && onClear && clearLabel && ( + {value && onClear && ( ( {...props} > {children} - {onClose && closeButtonLabel && ( + {onClose && ( {closeButtonLabel} diff --git a/packages/circuit-ui/components/CloseButton/CloseButton.spec.tsx b/packages/circuit-ui/components/CloseButton/CloseButton.spec.tsx index 492cfe7447..a24e12f800 100644 --- a/packages/circuit-ui/components/CloseButton/CloseButton.spec.tsx +++ b/packages/circuit-ui/components/CloseButton/CloseButton.spec.tsx @@ -16,29 +16,32 @@ import { describe, expect, it } from 'vitest'; import { createRef } from 'react'; -import { axe, render } from '../../util/test-utils.js'; +import { axe, render, screen } from '../../util/test-utils.js'; import { CloseButton } from './CloseButton.js'; describe('CloseButton', () => { it('should merge a custom class name with the default ones', () => { const className = 'foo'; - const { container } = render( - , - ); - const button = container.querySelector('button'); + render(Close); + const button = screen.getByRole('button', { name: 'Close' }); expect(button?.className).toContain(className); }); it('should forward a ref', () => { const ref = createRef(); - const { container } = render(); - const button = container.querySelector('button'); + render(Close); + const button = screen.getByRole('button', { name: 'Close' }); expect(ref.current).toBe(button); }); + it('should render with default translated label', () => { + render(); + expect(screen.getByText('Fermer')).toBeVisible(); + }); + it('should meet accessibility guidelines', async () => { - const { container } = render(); + const { container } = render(Close); const actual = await axe(container); expect(actual).toHaveNoViolations(); }); diff --git a/packages/circuit-ui/components/CloseButton/CloseButton.stories.tsx b/packages/circuit-ui/components/CloseButton/CloseButton.stories.tsx index 512fe7a53c..8dfaa1ea3f 100644 --- a/packages/circuit-ui/components/CloseButton/CloseButton.stories.tsx +++ b/packages/circuit-ui/components/CloseButton/CloseButton.stories.tsx @@ -24,7 +24,3 @@ export default { }; export const Base = (args: CloseButtonProps) => ; - -Base.args = { - children: 'Close', -}; diff --git a/packages/circuit-ui/components/CloseButton/CloseButton.tsx b/packages/circuit-ui/components/CloseButton/CloseButton.tsx index 1c7fbfa6c5..21ef991621 100644 --- a/packages/circuit-ui/components/CloseButton/CloseButton.tsx +++ b/packages/circuit-ui/components/CloseButton/CloseButton.tsx @@ -16,7 +16,9 @@ import { forwardRef } from 'react'; import { Close } from '@sumup-oss/icons'; -import { IconButton, type IconButtonProps } from '../Button/IconButton.js'; +import { IconButton, type IconButtonProps } from '../Button/index.js'; +import { useI18n } from '../../hooks/useI18n/useI18n.js'; +import { translations } from './translations/index.js'; export type CloseButtonProps = Omit; @@ -24,18 +26,19 @@ export type CloseButtonProps = Omit; * A generic close button. */ -export const CloseButton = forwardRef( - ({ label = 'Close', children = label, ...props }, ref) => ( +export const CloseButton = forwardRef((props, ref) => { + const { label, children = label, ...rest } = useI18n(props, translations); + return ( {children} - ), -); + ); +}); CloseButton.displayName = 'CloseButton'; diff --git a/packages/circuit-ui/components/CloseButton/translations/bg-BG.json b/packages/circuit-ui/components/CloseButton/translations/bg-BG.json new file mode 100644 index 0000000000..2d0c4f619a --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/bg-BG.json @@ -0,0 +1,3 @@ +{ + "label": "Затвори" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/cs-CZ.json b/packages/circuit-ui/components/CloseButton/translations/cs-CZ.json new file mode 100644 index 0000000000..c7c0665b6d --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/cs-CZ.json @@ -0,0 +1,3 @@ +{ + "label": "Zavřít" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/da-DK.json b/packages/circuit-ui/components/CloseButton/translations/da-DK.json new file mode 100644 index 0000000000..0f165dbd16 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/da-DK.json @@ -0,0 +1,3 @@ +{ + "label": "Luk" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/de-AT.json b/packages/circuit-ui/components/CloseButton/translations/de-AT.json new file mode 100644 index 0000000000..9b64b7ddee --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/de-AT.json @@ -0,0 +1,3 @@ +{ + "label": "Schließen" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/de-CH.json b/packages/circuit-ui/components/CloseButton/translations/de-CH.json new file mode 100644 index 0000000000..504f5295bc --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/de-CH.json @@ -0,0 +1,3 @@ +{ + "label": "Schliessen" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/de-DE.json b/packages/circuit-ui/components/CloseButton/translations/de-DE.json new file mode 100644 index 0000000000..9b64b7ddee --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/de-DE.json @@ -0,0 +1,3 @@ +{ + "label": "Schließen" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/de-LU.json b/packages/circuit-ui/components/CloseButton/translations/de-LU.json new file mode 100644 index 0000000000..9b64b7ddee --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/de-LU.json @@ -0,0 +1,3 @@ +{ + "label": "Schließen" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/el-CY.json b/packages/circuit-ui/components/CloseButton/translations/el-CY.json new file mode 100644 index 0000000000..a7d92d80f5 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/el-CY.json @@ -0,0 +1,3 @@ +{ + "label": "Κλείσιμο" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/el-GR.json b/packages/circuit-ui/components/CloseButton/translations/el-GR.json new file mode 100644 index 0000000000..a7d92d80f5 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/el-GR.json @@ -0,0 +1,3 @@ +{ + "label": "Κλείσιμο" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/en-AU.json b/packages/circuit-ui/components/CloseButton/translations/en-AU.json new file mode 100644 index 0000000000..676056bf2a --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/en-AU.json @@ -0,0 +1,3 @@ +{ + "label": "Close" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/en-GB.json b/packages/circuit-ui/components/CloseButton/translations/en-GB.json new file mode 100644 index 0000000000..676056bf2a --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/en-GB.json @@ -0,0 +1,3 @@ +{ + "label": "Close" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/en-IE.json b/packages/circuit-ui/components/CloseButton/translations/en-IE.json new file mode 100644 index 0000000000..676056bf2a --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/en-IE.json @@ -0,0 +1,3 @@ +{ + "label": "Close" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/en-MT.json b/packages/circuit-ui/components/CloseButton/translations/en-MT.json new file mode 100644 index 0000000000..676056bf2a --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/en-MT.json @@ -0,0 +1,3 @@ +{ + "label": "Close" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/en-US.json b/packages/circuit-ui/components/CloseButton/translations/en-US.json new file mode 100644 index 0000000000..676056bf2a --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/en-US.json @@ -0,0 +1,3 @@ +{ + "label": "Close" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/es-CL.json b/packages/circuit-ui/components/CloseButton/translations/es-CL.json new file mode 100644 index 0000000000..25e10e3f32 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/es-CL.json @@ -0,0 +1,3 @@ +{ + "label": "Cerrar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/es-CO.json b/packages/circuit-ui/components/CloseButton/translations/es-CO.json new file mode 100644 index 0000000000..25e10e3f32 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/es-CO.json @@ -0,0 +1,3 @@ +{ + "label": "Cerrar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/es-ES.json b/packages/circuit-ui/components/CloseButton/translations/es-ES.json new file mode 100644 index 0000000000..25e10e3f32 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/es-ES.json @@ -0,0 +1,3 @@ +{ + "label": "Cerrar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/es-MX.json b/packages/circuit-ui/components/CloseButton/translations/es-MX.json new file mode 100644 index 0000000000..25e10e3f32 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/es-MX.json @@ -0,0 +1,3 @@ +{ + "label": "Cerrar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/es-PE.json b/packages/circuit-ui/components/CloseButton/translations/es-PE.json new file mode 100644 index 0000000000..25e10e3f32 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/es-PE.json @@ -0,0 +1,3 @@ +{ + "label": "Cerrar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/es-US.json b/packages/circuit-ui/components/CloseButton/translations/es-US.json new file mode 100644 index 0000000000..25e10e3f32 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/es-US.json @@ -0,0 +1,3 @@ +{ + "label": "Cerrar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/et-EE.json b/packages/circuit-ui/components/CloseButton/translations/et-EE.json new file mode 100644 index 0000000000..0adcc73333 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/et-EE.json @@ -0,0 +1,3 @@ +{ + "label": "Sulge" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/fi-FI.json b/packages/circuit-ui/components/CloseButton/translations/fi-FI.json new file mode 100644 index 0000000000..9b45bf3b51 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/fi-FI.json @@ -0,0 +1,3 @@ +{ + "label": "Sulje" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/fr-BE.json b/packages/circuit-ui/components/CloseButton/translations/fr-BE.json new file mode 100644 index 0000000000..5658d3a619 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/fr-BE.json @@ -0,0 +1,3 @@ +{ + "label": "Fermer" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/fr-CH.json b/packages/circuit-ui/components/CloseButton/translations/fr-CH.json new file mode 100644 index 0000000000..5658d3a619 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/fr-CH.json @@ -0,0 +1,3 @@ +{ + "label": "Fermer" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/fr-FR.json b/packages/circuit-ui/components/CloseButton/translations/fr-FR.json new file mode 100644 index 0000000000..5658d3a619 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/fr-FR.json @@ -0,0 +1,3 @@ +{ + "label": "Fermer" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/fr-LU.json b/packages/circuit-ui/components/CloseButton/translations/fr-LU.json new file mode 100644 index 0000000000..5658d3a619 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/fr-LU.json @@ -0,0 +1,3 @@ +{ + "label": "Fermer" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/hr-HR.json b/packages/circuit-ui/components/CloseButton/translations/hr-HR.json new file mode 100644 index 0000000000..c77a459dec --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/hr-HR.json @@ -0,0 +1,3 @@ +{ + "label": "Zatvori" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/hu-HU.json b/packages/circuit-ui/components/CloseButton/translations/hu-HU.json new file mode 100644 index 0000000000..e8828e745e --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/hu-HU.json @@ -0,0 +1,3 @@ +{ + "label": "Bezárás" +} diff --git a/packages/circuit-ui/components/Dialog/translations/index.ts b/packages/circuit-ui/components/CloseButton/translations/index.ts similarity index 100% rename from packages/circuit-ui/components/Dialog/translations/index.ts rename to packages/circuit-ui/components/CloseButton/translations/index.ts diff --git a/packages/circuit-ui/components/CloseButton/translations/it-CH.json b/packages/circuit-ui/components/CloseButton/translations/it-CH.json new file mode 100644 index 0000000000..f99e77e802 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/it-CH.json @@ -0,0 +1,3 @@ +{ + "label": "Chiudi" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/it-IT.json b/packages/circuit-ui/components/CloseButton/translations/it-IT.json new file mode 100644 index 0000000000..f99e77e802 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/it-IT.json @@ -0,0 +1,3 @@ +{ + "label": "Chiudi" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/lt-LT.json b/packages/circuit-ui/components/CloseButton/translations/lt-LT.json new file mode 100644 index 0000000000..df1a81ad79 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/lt-LT.json @@ -0,0 +1,3 @@ +{ + "label": "Uždaryti" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/lv-LV.json b/packages/circuit-ui/components/CloseButton/translations/lv-LV.json new file mode 100644 index 0000000000..c50bc06085 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/lv-LV.json @@ -0,0 +1,3 @@ +{ + "label": "Aizvērt" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/nb-NO.json b/packages/circuit-ui/components/CloseButton/translations/nb-NO.json new file mode 100644 index 0000000000..669695e99c --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/nb-NO.json @@ -0,0 +1,3 @@ +{ + "label": "Lukk" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/nl-BE.json b/packages/circuit-ui/components/CloseButton/translations/nl-BE.json new file mode 100644 index 0000000000..eabed0e195 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/nl-BE.json @@ -0,0 +1,3 @@ +{ + "label": "Sluit" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/nl-NL.json b/packages/circuit-ui/components/CloseButton/translations/nl-NL.json new file mode 100644 index 0000000000..0fd717d4c2 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/nl-NL.json @@ -0,0 +1,3 @@ +{ + "label": "Sluiten" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/pl-PL.json b/packages/circuit-ui/components/CloseButton/translations/pl-PL.json new file mode 100644 index 0000000000..b1ebd3c962 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/pl-PL.json @@ -0,0 +1,3 @@ +{ + "label": "Zamknij" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/pt-BR.json b/packages/circuit-ui/components/CloseButton/translations/pt-BR.json new file mode 100644 index 0000000000..0ada10419d --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/pt-BR.json @@ -0,0 +1,3 @@ +{ + "label": "Fechar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/pt-PT.json b/packages/circuit-ui/components/CloseButton/translations/pt-PT.json new file mode 100644 index 0000000000..0ada10419d --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/pt-PT.json @@ -0,0 +1,3 @@ +{ + "label": "Fechar" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/ro-RO.json b/packages/circuit-ui/components/CloseButton/translations/ro-RO.json new file mode 100644 index 0000000000..d71463856f --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/ro-RO.json @@ -0,0 +1,3 @@ +{ + "label": "Închide" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/sk-SK.json b/packages/circuit-ui/components/CloseButton/translations/sk-SK.json new file mode 100644 index 0000000000..7c457e9d35 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/sk-SK.json @@ -0,0 +1,3 @@ +{ + "label": "Zatvoriť" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/sl-SI.json b/packages/circuit-ui/components/CloseButton/translations/sl-SI.json new file mode 100644 index 0000000000..f8af87191b --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/sl-SI.json @@ -0,0 +1,3 @@ +{ + "label": "Zapri" +} diff --git a/packages/circuit-ui/components/CloseButton/translations/sv-SE.json b/packages/circuit-ui/components/CloseButton/translations/sv-SE.json new file mode 100644 index 0000000000..d8da655609 --- /dev/null +++ b/packages/circuit-ui/components/CloseButton/translations/sv-SE.json @@ -0,0 +1,3 @@ +{ + "label": "Stäng" +} diff --git a/packages/circuit-ui/components/Dialog/Dialog.tsx b/packages/circuit-ui/components/Dialog/Dialog.tsx index 12b92d1d03..ac9d5e2efc 100644 --- a/packages/circuit-ui/components/Dialog/Dialog.tsx +++ b/packages/circuit-ui/components/Dialog/Dialog.tsx @@ -36,11 +36,9 @@ import { clsx } from '../../styles/clsx.js'; import { useClickOutside } from '../../hooks/useClickOutside/index.js'; import { useEscapeKey } from '../../hooks/useEscapeKey/index.js'; import { useLatest } from '../../hooks/useLatest/index.js'; -import { useI18n } from '../../hooks/useI18n/useI18n.js'; import { useSwipe } from '../../hooks/useSwipe/index.js'; import classes from './Dialog.module.css'; -import { translations } from './translations/index.js'; type DataAttribute = `data-${string}`; @@ -119,8 +117,8 @@ export interface DialogProps extends PublicDialogProps { } export const Dialog = forwardRef( - (props, ref) => { - const { + ( + { open, isModal = false, children, @@ -136,7 +134,9 @@ export const Dialog = forwardRef( locale, style, ...rest - } = useI18n(props, translations); + }, + ref, + ) => { const dialogRef = useRef(null); const openRef = useLatest(open); const isModalRef = useLatest(isModal); diff --git a/packages/circuit-ui/components/Dialog/translations/bg-BG.json b/packages/circuit-ui/components/Dialog/translations/bg-BG.json deleted file mode 100644 index ddf333d07f..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/bg-BG.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Затвори" -} diff --git a/packages/circuit-ui/components/Dialog/translations/cs-CZ.json b/packages/circuit-ui/components/Dialog/translations/cs-CZ.json deleted file mode 100644 index 78f6b38afd..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/cs-CZ.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Zavřít" -} diff --git a/packages/circuit-ui/components/Dialog/translations/da-DK.json b/packages/circuit-ui/components/Dialog/translations/da-DK.json deleted file mode 100644 index 12c5d6f111..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/da-DK.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Luk" -} diff --git a/packages/circuit-ui/components/Dialog/translations/de-AT.json b/packages/circuit-ui/components/Dialog/translations/de-AT.json deleted file mode 100644 index b6226360c4..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/de-AT.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Schließen" -} diff --git a/packages/circuit-ui/components/Dialog/translations/de-CH.json b/packages/circuit-ui/components/Dialog/translations/de-CH.json deleted file mode 100644 index ddcc840f48..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/de-CH.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Schliessen" -} diff --git a/packages/circuit-ui/components/Dialog/translations/de-DE.json b/packages/circuit-ui/components/Dialog/translations/de-DE.json deleted file mode 100644 index b6226360c4..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/de-DE.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Schließen" -} diff --git a/packages/circuit-ui/components/Dialog/translations/de-LU.json b/packages/circuit-ui/components/Dialog/translations/de-LU.json deleted file mode 100644 index b6226360c4..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/de-LU.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Schließen" -} diff --git a/packages/circuit-ui/components/Dialog/translations/el-CY.json b/packages/circuit-ui/components/Dialog/translations/el-CY.json deleted file mode 100644 index 33d5e74c1d..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/el-CY.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Κλείσιμο" -} diff --git a/packages/circuit-ui/components/Dialog/translations/el-GR.json b/packages/circuit-ui/components/Dialog/translations/el-GR.json deleted file mode 100644 index 33d5e74c1d..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/el-GR.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Κλείσιμο" -} diff --git a/packages/circuit-ui/components/Dialog/translations/en-AU.json b/packages/circuit-ui/components/Dialog/translations/en-AU.json deleted file mode 100644 index 5fb33ad8f3..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/en-AU.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Close" -} diff --git a/packages/circuit-ui/components/Dialog/translations/en-GB.json b/packages/circuit-ui/components/Dialog/translations/en-GB.json deleted file mode 100644 index 5fb33ad8f3..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/en-GB.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Close" -} diff --git a/packages/circuit-ui/components/Dialog/translations/en-IE.json b/packages/circuit-ui/components/Dialog/translations/en-IE.json deleted file mode 100644 index 5fb33ad8f3..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/en-IE.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Close" -} diff --git a/packages/circuit-ui/components/Dialog/translations/en-MT.json b/packages/circuit-ui/components/Dialog/translations/en-MT.json deleted file mode 100644 index 5fb33ad8f3..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/en-MT.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Close" -} diff --git a/packages/circuit-ui/components/Dialog/translations/en-US.json b/packages/circuit-ui/components/Dialog/translations/en-US.json deleted file mode 100644 index 5fb33ad8f3..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/en-US.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Close" -} diff --git a/packages/circuit-ui/components/Dialog/translations/es-CL.json b/packages/circuit-ui/components/Dialog/translations/es-CL.json deleted file mode 100644 index b46dc02916..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/es-CL.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Cerrar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/es-CO.json b/packages/circuit-ui/components/Dialog/translations/es-CO.json deleted file mode 100644 index b46dc02916..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/es-CO.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Cerrar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/es-ES.json b/packages/circuit-ui/components/Dialog/translations/es-ES.json deleted file mode 100644 index b46dc02916..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/es-ES.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Cerrar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/es-MX.json b/packages/circuit-ui/components/Dialog/translations/es-MX.json deleted file mode 100644 index b46dc02916..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/es-MX.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Cerrar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/es-PE.json b/packages/circuit-ui/components/Dialog/translations/es-PE.json deleted file mode 100644 index b46dc02916..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/es-PE.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Cerrar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/es-US.json b/packages/circuit-ui/components/Dialog/translations/es-US.json deleted file mode 100644 index b46dc02916..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/es-US.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Cerrar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/et-EE.json b/packages/circuit-ui/components/Dialog/translations/et-EE.json deleted file mode 100644 index a9d5010617..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/et-EE.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Sulge" -} diff --git a/packages/circuit-ui/components/Dialog/translations/fi-FI.json b/packages/circuit-ui/components/Dialog/translations/fi-FI.json deleted file mode 100644 index 10d8058a44..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/fi-FI.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Sulje" -} diff --git a/packages/circuit-ui/components/Dialog/translations/fr-BE.json b/packages/circuit-ui/components/Dialog/translations/fr-BE.json deleted file mode 100644 index b071a84d05..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/fr-BE.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Fermer" -} diff --git a/packages/circuit-ui/components/Dialog/translations/fr-CH.json b/packages/circuit-ui/components/Dialog/translations/fr-CH.json deleted file mode 100644 index b071a84d05..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/fr-CH.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Fermer" -} diff --git a/packages/circuit-ui/components/Dialog/translations/fr-FR.json b/packages/circuit-ui/components/Dialog/translations/fr-FR.json deleted file mode 100644 index b071a84d05..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/fr-FR.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Fermer" -} diff --git a/packages/circuit-ui/components/Dialog/translations/fr-LU.json b/packages/circuit-ui/components/Dialog/translations/fr-LU.json deleted file mode 100644 index b071a84d05..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/fr-LU.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Fermer" -} diff --git a/packages/circuit-ui/components/Dialog/translations/hr-HR.json b/packages/circuit-ui/components/Dialog/translations/hr-HR.json deleted file mode 100644 index 58c4e9bbb8..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/hr-HR.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Zatvori" -} diff --git a/packages/circuit-ui/components/Dialog/translations/hu-HU.json b/packages/circuit-ui/components/Dialog/translations/hu-HU.json deleted file mode 100644 index f1f68c32e6..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/hu-HU.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Bezárás" -} diff --git a/packages/circuit-ui/components/Dialog/translations/it-CH.json b/packages/circuit-ui/components/Dialog/translations/it-CH.json deleted file mode 100644 index 73c3efb158..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/it-CH.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Chiudi" -} diff --git a/packages/circuit-ui/components/Dialog/translations/it-IT.json b/packages/circuit-ui/components/Dialog/translations/it-IT.json deleted file mode 100644 index 73c3efb158..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/it-IT.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Chiudi" -} diff --git a/packages/circuit-ui/components/Dialog/translations/lt-LT.json b/packages/circuit-ui/components/Dialog/translations/lt-LT.json deleted file mode 100644 index b55cf74468..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/lt-LT.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Uždaryti" -} diff --git a/packages/circuit-ui/components/Dialog/translations/lv-LV.json b/packages/circuit-ui/components/Dialog/translations/lv-LV.json deleted file mode 100644 index 486fc0ee7a..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/lv-LV.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Aizvērt" -} diff --git a/packages/circuit-ui/components/Dialog/translations/nb-NO.json b/packages/circuit-ui/components/Dialog/translations/nb-NO.json deleted file mode 100644 index 72f78d9c6a..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/nb-NO.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Lukk" -} diff --git a/packages/circuit-ui/components/Dialog/translations/nl-BE.json b/packages/circuit-ui/components/Dialog/translations/nl-BE.json deleted file mode 100644 index 538d49ed54..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/nl-BE.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Sluit" -} diff --git a/packages/circuit-ui/components/Dialog/translations/nl-NL.json b/packages/circuit-ui/components/Dialog/translations/nl-NL.json deleted file mode 100644 index f2a9127e10..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/nl-NL.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Sluiten" -} diff --git a/packages/circuit-ui/components/Dialog/translations/pl-PL.json b/packages/circuit-ui/components/Dialog/translations/pl-PL.json deleted file mode 100644 index a1cb3d0112..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/pl-PL.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Zamknij" -} diff --git a/packages/circuit-ui/components/Dialog/translations/pt-BR.json b/packages/circuit-ui/components/Dialog/translations/pt-BR.json deleted file mode 100644 index 12ce2fa58f..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/pt-BR.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Fechar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/pt-PT.json b/packages/circuit-ui/components/Dialog/translations/pt-PT.json deleted file mode 100644 index 12ce2fa58f..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/pt-PT.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Fechar" -} diff --git a/packages/circuit-ui/components/Dialog/translations/ro-RO.json b/packages/circuit-ui/components/Dialog/translations/ro-RO.json deleted file mode 100644 index 58d8225420..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/ro-RO.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Închide" -} diff --git a/packages/circuit-ui/components/Dialog/translations/sk-SK.json b/packages/circuit-ui/components/Dialog/translations/sk-SK.json deleted file mode 100644 index 73e63be91a..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/sk-SK.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Zatvoriť" -} diff --git a/packages/circuit-ui/components/Dialog/translations/sl-SI.json b/packages/circuit-ui/components/Dialog/translations/sl-SI.json deleted file mode 100644 index 364b505566..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/sl-SI.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Zapri" -} diff --git a/packages/circuit-ui/components/Dialog/translations/sv-SE.json b/packages/circuit-ui/components/Dialog/translations/sv-SE.json deleted file mode 100644 index 2d332d9d2a..0000000000 --- a/packages/circuit-ui/components/Dialog/translations/sv-SE.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "closeButtonLabel": "Stäng" -} diff --git a/packages/circuit-ui/components/NotificationBanner/NotificationBanner.tsx b/packages/circuit-ui/components/NotificationBanner/NotificationBanner.tsx index 94f46d9803..dc7962b06f 100644 --- a/packages/circuit-ui/components/NotificationBanner/NotificationBanner.tsx +++ b/packages/circuit-ui/components/NotificationBanner/NotificationBanner.tsx @@ -54,7 +54,7 @@ type CloseProps = * Text label for the close button for screen readers. * Important for accessibility. */ - closeButtonLabel: string; + closeButtonLabel?: string; } | { onClose?: never; closeButtonLabel?: never }; @@ -195,7 +195,7 @@ export const NotificationBanner = forwardRef< size="s" /> {image?.src && } - {onClose && closeButtonLabel && ( + {onClose && ( {closeButtonLabel} diff --git a/packages/circuit-ui/components/NotificationInline/NotificationInline.tsx b/packages/circuit-ui/components/NotificationInline/NotificationInline.tsx index 75363c7a77..706fd99a8c 100644 --- a/packages/circuit-ui/components/NotificationInline/NotificationInline.tsx +++ b/packages/circuit-ui/components/NotificationInline/NotificationInline.tsx @@ -57,7 +57,7 @@ type CloseProps = * Text label for the close button for screen readers. * Important for accessibility. */ - closeButtonLabel: string; + closeButtonLabel?: string; } | { onClose?: never; closeButtonLabel?: never }; @@ -179,7 +179,7 @@ export const NotificationInline = forwardRef< )} - {onClose && closeButtonLabel && ( + {onClose && ( {closeButtonLabel} diff --git a/packages/circuit-ui/components/SearchInput/SearchInput.tsx b/packages/circuit-ui/components/SearchInput/SearchInput.tsx index a8ba3a13a2..c2a479edc6 100644 --- a/packages/circuit-ui/components/SearchInput/SearchInput.tsx +++ b/packages/circuit-ui/components/SearchInput/SearchInput.tsx @@ -89,7 +89,7 @@ export const SearchInput = forwardRef( aria-hidden="true" /> )} - {...(value && onClear && clearLabel + {...(value && onClear ? { renderSuffix: (renderProps) => ( diff --git a/packages/circuit-ui/components/SidePanel/components/Header/Header.tsx b/packages/circuit-ui/components/SidePanel/components/Header/Header.tsx index bb23beabd2..8291e039fc 100644 --- a/packages/circuit-ui/components/SidePanel/components/Header/Header.tsx +++ b/packages/circuit-ui/components/SidePanel/components/Header/Header.tsx @@ -59,10 +59,8 @@ export const Header = ({ {headline} - {closeButtonLabel && ( - - {closeButtonLabel} - - )} + + {closeButtonLabel} + ); diff --git a/packages/circuit-ui/components/Tag/Tag.tsx b/packages/circuit-ui/components/Tag/Tag.tsx index 46cdcdfe94..4dd91faaf8 100644 --- a/packages/circuit-ui/components/Tag/Tag.tsx +++ b/packages/circuit-ui/components/Tag/Tag.tsx @@ -66,7 +66,7 @@ type RemoveProps = * Text label for the remove icon for screen readers. * Important for accessibility. */ - removeButtonLabel: string; + removeButtonLabel?: string; } | { onRemove?: never; removeButtonLabel?: never };