Skip to content

Make Icon / Logo replaceable by NOT embedding it. Use <img> with URL instead. #1308

@rvveber

Description

@rvveber

The docs logo can not be changed through K8s configmaps at deploy-time.

Currently, the Logo / Icon used in the Header

  • is using the icon-docs.svg from frontend/apps/impress/src/assets/icons directory.
  • is embedded into the page and therefore bundled.

Desirably, the Logo / Icon used in the Header

  • should be icon-docs.svg from frontend/apps/impress/public/assets directory.
  • should be loaded via URL on browser access,

import IconDocs from '@/assets/icons/icon-docs.svg';

<IconDocs
data-testid="header-icon-docs"
width={32}
color={colorsTokens['primary-text']}
aria-hidden="true"
/>

Is there a reason for the SVG to be embedded here?

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions