-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement for service section #592
Conversation
Sorry, my last PR was closed due to a force push, and I’m unable to recover it for now. I’ve created a new PR, and I assure you that this will not happen again. |
Thanks. That's an improvement, but your commit message still does not follow our guidance. In particular;
Please rewrite your commit message ( I'd also like you to consider the problems raised in #591 which came up because of your work on this section. I'm loath to accept this pull request given those issues, because it's like putting lipstick on a pig. Have you used Sugar? What happened when you visited the web site using Sugar? |
I understand it's just a CSS update, and I’m keeping it separate because I’m exploring ways to solve the aforementioned issues while also trying out Sugar. For now, I’ve updated the commit message. |
Thanks. I checked one item in my reponse above. You will note how GitHub has highlighted your commit message as violating convention; GitHub breaks up the message with ellipsis because you haven't followed the git convention of a single short one line summary followed by detail after a blank line. You have already shown a difficulty with newlines. You can use a key marked enter or return to add newlines. Two newlines in a row is what we call a blank line. |
Improved the layout for better visual appeal and responsiveness across the different screen sizes.
Thanks for the guidance and sorry for inconveniences. |
Thanks, change noted. @pikurasa your turn. |
I wanted to highlight that we should refrain from making custom modifications to the default Bootstrap grid system (such as changing the col-md- and col-sm- classes). By modifying or overriding these classes, we risk breaking the built-in responsiveness, which could lead to inconsistent layouts across different screen sizes and make the codebase harder to maintain over time. Instead, let’s stick with Bootstrap’s built-in grid classes. If specific layout adjustments are necessary, we can introduce additional custom styles or media queries without modifying the core grid system. What are your thoughts on this, @quozl ? |
But as mentioned before, all the new CSS should be written in custom.css. |
Yes, new CSS should be written in custom.css. However, I wanted to point out that you made changes to the col-md- and col-sm- classes, which are part of Bootstrap's grid system. Modifying these classes directly can disrupt Bootstrap's built-in responsiveness and consistency. Instead, we should avoid altering these core classes and use custom styles or media queries in custom.css for any additional adjustments. |
@soumyaranjan-panda |
Improved the layout for better visual appeal and responsiveness across the different screen sizes.
Improved the layout for better visual appeal and responsiveness across the different screen sizes.
Thanks, good to know. |
Description:
Enhance responsiveness and styling of service section with equal-sized boxes, centered content, and consistent spacing.
Problem:
Icons in the service section were misaligned, and the spacing between elements was inconsistent. This led to a cluttered appearance and reduced responsiveness, impacting the user experience across different screen sizes.
Screenshot:
Testing:
Verified changes on a local Linux-based environment.