jest dependency is not added in the package.json

[apsinghdev]

@walterbender I guess @Commanderk3 has mistakenly removed the jest dependency from the package.json file. This results in other contributors not having jest in their local development environment to run tests.

Originally posted by @apsinghdev in #4132 (comment)

[apsinghdev]

@Commanderk3 here is what I am getting to my side.

[Commanderk3]

@apsinghdev Does your package.json has "test": "jest"

[Commanderk3]

If you error is like this :

then it is because of newly added config and setup file. After removing these files, it works fine.

[apsinghdev]

@apsinghdev Does your package.json has "test": "jest"

It does. My question is, how are you installing Jest in the project? Are you installing using npm or by adding a link directly in the root index.html?

[Commanderk3]

npm

[apsinghdev]

npm

hmm. then shouldn't be there jest reference in devDependencies so that when someone execute npm i first time, jest gets installed to their development env?

[Commanderk3]

it should actually but as I said I kept the package.json file just like @omsuneri edited it the last time. After again doing an :
npm install --save-dev jest
This showed up :->

Try installing it again, it should work then.

[omsuneri]

I will be adding all the setup guide for test in a readme soon @apsinghdev @Commanderk3 so no one will get confused while setting up the jest

[apsinghdev]

it should actually but as I said I kept the package.json file just like @omsuneri edited it the last time. After again doing an : npm install --save-dev jest This showed up :->

Try installing it again, it should work then.

This is what I am telling. This extra step of installing jest should not be there as we have devDependencies for such tasks.

[omsuneri]

@apsinghdev once there is required to install the jest while setting up then I don't think so

[apsinghdev]

@apsinghdev once there is required to install the jest while setting up then I don't think so

I didn't get it. do you mean adding instructions in readme file of installing jest using npm i --save-dev jest?

[omsuneri]

@apsinghdev yess to guide to use testing

[apsinghdev]

@apsinghdev yes to guide to use testing

Adding instructions on how to run tests is important, but this approach defeats the purpose of the package.json file, which contains all the dependencies we need, including the ones we need in development and production. Also, if each contributor installs jest on their own, they'll end up having different versions of it, and this will cause problems.

[omsuneri]

@apsinghdev I ll try to figure out the best solution for this soon till then we should rely on the same what we are doing.

[apsinghdev]

@omsuneri @Commanderk3 Please don't push unfinished work.

Running npm run test creates many files because there are so many extra configurations that we don't need in the beginning.

I guess @walterbender will also agree on the point that we have to implement the test iteratively. We can write unit tests for files without many advanced configs and later on, can add more things when we feel the need of it.

[omsuneri]

@apsinghdev can you please summarise like what need to be changed

[Commanderk3]

@apsinghdev Got it ! The recent test file is actually a collaborative work. So I pushed my part. But I will keep that in mind.

[omsuneri]

Actually I was writing a test file for platform style and that requires these modules to be exported to run that's the reason for config.js

[apsinghdev]

@Commanderk3 @omsuneri Currently, I am fixing this dependency error and removing the configs we don't need. Let's lay a clear plan for it in tomorrow's meeting

[omsuneri]

@apsinghdev yaa that's might be the better way to resolve

[Commanderk3]

@Commanderk3 @omsuneri Currently, I am fixing this dependency error and removing the configs we don't need. Let's lay a clear plan for it in tomorrow's meeting

That sounds great sir. Also pardon me if I messed up real bad. I look forward to meeting you. 👍

[apsinghdev]

@Commanderk3 @omsuneri Currently, I am fixing this dependency error and removing the configs we don't need. Let's lay a clear plan for it in tomorrow's meeting.

That sounds great sir. Also, pardon me if I messed up real bad. I look forward to meeting you. 👍

You don't need to sorry for this. Just be a little cautious before pushing code. Tests are written nicely.

[omsuneri]

@apsinghdev might be because of me too :/

[omsuneri]

@apsinghdev i think you must close it as the issue is solved

[apsinghdev]

@apsinghdev i think you must close it as the issue is solved

Yeah, make sense.

[omsuneri]

Yuppp. 😊