Temperament Widget: Arbitrary adjustments expressed in cents in relation to a given system

[pikurasa]

(FYI: I'm going to solicit a bit more feedback on this before asking anyone to work on this.)

Current Behavior

Currently, using "arbitrary" in Temperament Widget allows you to adjust a pitch, expressed in hertz. However, based on feedback, it would be nice to:

1. Be able to input hertz directly (<-- question: do we ever really need this?)
2. Also be able to express the adjustment in cents, in relationship to the starting temperament system. Upon export, the pitch blocks could have cents block containers.

Desired Behavior

The ability to modify this number as cents in relation to the pitch system:

(Question: Do we ever really need to be able to modify hertz directly? Is that ever useful, musically speaking?)

[omsuneri]

What do you think about it should i move forward to make the changes of whole number hertz to decimal if i guess it correct @pikurasa

[pikurasa]

What do you think about it should i move forward to make the changes of whole number hertz to decimal if i guess it correct @pikurasa

This is not about changing to whole numbers. This is about changing to https://en.wikipedia.org/wiki/Cent_(music)

Someone working on this would need to first propose a new design.

[dubeanant]

Thank you for the clarification, @pikurasa . I’ll start by proposing a new design based on the idea of expressing adjustments in cents instead of hertz. I’ll share a draft for feedback before moving forward with the implementation.

Does that sound good to you?

[pikurasa]

Thank you for the clarification, @pikurasa . I’ll start by proposing a new design based on the idea of expressing adjustments in cents instead of hertz. I’ll share a draft for feedback before moving forward with the implementation.

Does that sound good to you?

Yes.

[dubeanant]

@pikurasa ,If you'd like, I can raise an issue regarding the non-functional close button. Additionally, I noticed another problem: after selecting a number to edit, I'm unable to choose another number to modify as cents until I reopen the temperament widget. Let me know if you'd like me to open an issue for this as well.

[dubeanant]

Hi @walterbender ,

I think @pikurasa might be busy, so I wanted to ask if you could help me with this issue and I've noticed two problems: the close button on the temperament widget isn't working, and after selecting a number to edit as hertz, I can't choose another number to modify unless I reopen the widget.

If you're available, I'd appreciate any guidance. Should I go ahead and raise issues for these bugs?

[omsuneri]

@dubeanant I think go ahead with the new issue I ll try to work on it

[walterbender]

I think the changes suggested for the widget itself make sense. And under the hood, we generally manage cents properly, but I would not be surprised if we didn't miss a few corner cases. But I am not sure how we'd want to handle cents in the UX of the pitch block. Adding a third input by default seems excessive. Maybe a new advanced block pitchWithCents?

[dubeanant]

@omsuneri , I'll raise an issue for the problems with the close button and the widget behavior when editing in hertz. I'll start working on it, but feel free to pick it up this current issue. Let me know if you need any help!

[omsuneri]

@dubeanant I m willing to resolve this issue as from many days i m working around the temperament selection and its source code

[dubeanant]

Hello @walterbender ,

I wanted to inform you that I have raised an issue (#4017) regarding the close button functionality in the Temperament Widget. However, I noticed that everything seems to be working correctly now. Did you make any corrections? Should I go ahead and close the issue?

[dubeanant]

Hello @walterbender ,

Given your feedback, I’m wondering what we should do with the current issue regarding arbitrary adjustments expressed in cents. Do you think this is unnecessary, or should we proceed with it? If not, I can shift my focus to another issue. Let me know your thoughts.

[walterbender]

I think there is some value in allowing adjustment by cents.

…

On Mon, Sep 30, 2024 at 7:14 AM dubeanant ***@***.***> wrote: Hello @walterbender <https://github.com/walterbender> , Given your feedback, I’m wondering what we should do with the current issue regarding arbitrary adjustments expressed in cents. Do you think this is unnecessary, or should we proceed with it? If not, I can shift my focus to another issue. Let me know your thoughts. — Reply to this email directly, view it on GitHub <#3920 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6PXYKBTFFXDKACM4IKKU3ZZEW7ZAVCNFSM6AAAAABJ6YNN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBSHA4TGNBTGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Walter Bender Sugar Labs https://www.sugarlabs.org <http://www.sugarlabs.org>

[pikurasa]

The feedback I've been receiving from musicians is that arbitration in cents is a much more valuable representation than hertz, especially for something like our temperament widget. So, we may even want to consider replacing hertz arbitration with cents arbitration for the temperament widget (for hertz, we do have pitch staircase after all, which is a better way to build with hertz).

As for what arbitrating pitch to cents should look like, I think we can use the semi-tone transpose block which now has cents capabilities.

For example, exporting an otherwise 12EDO custom temperament with an additional pitch at 33 cents above pitch class zero, it would export the following:

[dubeanant]

Hello @walterbender ,

I’ve encountered an issue where, when searching for blocks, hovering over an option immediately replaces the search query in the search box with the block's name, even if the option hasn't been selected yet. This behavior can be frustrating as it disrupts the current search input.

It would be more user-friendly if the search box only updated after the block is actually chosen. Let me know what you think!

[walterbender]

@dubeanant please write up a separate issue.

[dubeanant]

yah okay, i will do that

[dubeanant]

Hey @pikurasa , is it okay if I go ahead and redesign the entire arbitrary temperament section? For the 'cents' part, we just need to replace it with frequency, correct? This will allow users to adjust it in cents.