Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add beginner's guide #369

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

add beginner's guide #369

wants to merge 5 commits into from

Conversation

Sumit-pd
Copy link

No description provided.

@Sumit-pd
Copy link
Author

@niloysikdar I have updated the pr can you check!

@walterbender
Copy link
Member

The guide reads well.
Comment/question: The changes to singer belong in a separate PR. And if we are going to export those variables, shouldn't we change their names to make it clear that they are not local/private?

@Sumit-pd
Copy link
Author

I added the export because the PR run was failing. Voice.tsx uses variables imported from 'singer,' but they were not exported from 'singer,' causing the failure. Should I include the export changes in a separate PR along with changes to variable names? @walterbender

This reverts commit 4c471f8.
@pikurasa
Copy link
Collaborator

pikurasa commented Jan 7, 2024

@meganindya Please check this out when you have the chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants