Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature Request: Use localized member names #486

Open
sruenwg opened this issue Jul 18, 2024 · 7 comments
Open

🚀 Feature Request: Use localized member names #486

sruenwg opened this issue Jul 18, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@sruenwg
Copy link
Collaborator

sruenwg commented Jul 18, 2024

Describe the solution

This is a request to always show member names at least in the currently selected site language.

Member names currently appear on the site in:

  1. fixed, untranslated strings (clip search dialog),
  2. channel names (livestream pages and video modal), and
  3. auto-translated texts (events page).

This ticket is about 1 and 2.
Here, the member's name / channel name is accompanied by their avatar and hence there is presumably no issue for most fans regardless of whether the name matches the site language, but from an accessibility standpoint I believe this language mismatch is not ideal. (E.g. this design is not friendly to new fans who may have a hard time distinguishing members just from their avatars.)

My suggestion would thus be to either:

  1. (preferred) display member names in both the original language (Japanese for JP members, English for EN members) and the current site language (e.g. '花芽すみれ (Sumire Kaga)' and 'Arya Kuroha' on /en and '花芽すみれ' and 'Arya Kuroha (黒刃アリヤ)' on /ja), or
  2. display member names only in the current site language (e.g. 花芽すみれ is always 'Sumire Kaga' on /en and '花芽すみれ' on /ja).
@sruenwg sruenwg added the enhancement New feature or request label Jul 18, 2024
@sruenwg
Copy link
Collaborator Author

sruenwg commented Jul 22, 2024

@sugar-cat7 I'd like to implement this, but do you think you would prefer option 1 (original + localized name) or 2 (just localized name)?

I still prefer 1 personally, but I realized that a lot of names might get truncated (like 橘ひなの's already is) if both languages are included.
image
Though this might not be too big an issue if we put the localized name first.
image
Or maybe we can have just the localized name in video cards but both names elsewhere (like in the modal once the user clicks on the card) — up to you.

Please also let me know if you have a preferred format, e.g. {localizedName} ({originalName}), {localizedName} / {originalName}, or something else.

@sugar-cat7
Copy link
Owner

sugar-cat7 commented Jul 23, 2024

@sruenwg
Personally, I think option 1 is better!

@sruenwg
Copy link
Collaborator Author

sruenwg commented Jul 24, 2024

@sugar-cat7

I would like to keep the original channel name displayed as it is.

I see you had this in a previous version of your message — would you rather we kept the channel names as is?
I'm asking because I'd hate to make any changes you disagree with.

@sugar-cat7
Copy link
Owner

@sruenwg
Thank you for confirming 🙏

In conclusion, I think option 1 is fine as proposed! (Even if the original channel name already includes a translated channel name)

Currently, my thinking is that if we need to normalize an original channel name like "橘ひなの / Hinano Tachibana" to "橘ひなの", it would be better to handle it in the backend (since we are deploying to multi-channels such as Discord Bot, etc.). Therefore, from the frontend perspective, we can go with the format proposed in option 1: {original Name} ({translated Name} according to the language).

@sruenwg
Copy link
Collaborator Author

sruenwg commented Jul 24, 2024

Ah good point, seems the scope of this is bigger than I anticipated.

I am not generally a fan of formatting strings on the backend, but that does seem like a good approach if we want to be consistent across the different services (web app and Discord bot).
I'm definitely not opposed to the idea since it seems we already do something similar with Livestream.formattedDateString.

In that case, I think I will leave this ticket for you when you have time to make those backend changes.

@sugar-cat7
Copy link
Owner

I apologize for the long wait on the backend...🫠

@sruenwg
Copy link
Collaborator Author

sruenwg commented Jul 25, 2024

No need to apologize! I don't mean to rush you so I'm sorry if I made you feel that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants