-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Feature Request: Use localized member names #486
Comments
@sugar-cat7 I'd like to implement this, but do you think you would prefer option 1 (original + localized name) or 2 (just localized name)? I still prefer 1 personally, but I realized that a lot of names might get truncated (like 橘ひなの's already is) if both languages are included. Please also let me know if you have a preferred format, e.g. |
@sruenwg |
I see you had this in a previous version of your message — would you rather we kept the channel names as is? |
@sruenwg In conclusion, I think option 1 is fine as proposed! (Even if the original channel name already includes a translated channel name) Currently, my thinking is that if we need to normalize an original channel name like "橘ひなの / Hinano Tachibana" to "橘ひなの", it would be better to handle it in the backend (since we are deploying to multi-channels such as Discord Bot, etc.). Therefore, from the frontend perspective, we can go with the format proposed in option 1: {original Name} ({translated Name} according to the language). |
Ah good point, seems the scope of this is bigger than I anticipated. I am not generally a fan of formatting strings on the backend, but that does seem like a good approach if we want to be consistent across the different services (web app and Discord bot). In that case, I think I will leave this ticket for you when you have time to make those backend changes. |
I apologize for the long wait on the backend...🫠 |
No need to apologize! I don't mean to rush you so I'm sorry if I made you feel that way. |
Describe the solution
This is a request to always show member names at least in the currently selected site language.
Member names currently appear on the site in:
This ticket is about 1 and 2.
Here, the member's name / channel name is accompanied by their avatar and hence there is presumably no issue for most fans regardless of whether the name matches the site language, but from an accessibility standpoint I believe this language mismatch is not ideal. (E.g. this design is not friendly to new fans who may have a hard time distinguishing members just from their avatars.)
My suggestion would thus be to either:
/en
and '花芽すみれ' and 'Arya Kuroha (黒刃アリヤ)' on/ja
), or/en
and '花芽すみれ' on/ja
).The text was updated successfully, but these errors were encountered: