Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› BUG: Some events show Web Links heading with no listed web links #201

Open
sruenwg opened this issue Feb 17, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@sruenwg
Copy link
Collaborator

sruenwg commented Feb 17, 2024

What operating system are you using?

Mac

Describe the Bug

Sometimes, an event displays the Web Links heading with no links listed beneath it.

image

Some events properly hide the heading when there are no links β€” this issue is about the events which don't exhibit this behavior.
On the pages where the heading is there, there seems to actually be an empty link (<a></a>) element listead beneath it.
image

The frontend currently performs a check for event.webPageLinks.length > 0 before showing the Web Links heading, so I suspect this is a consistency issue on the backend where blank or invalid links are sometimes placed in event.webPageLinks.

The expected behavior is for the Web Links heading to be displayed only when there is at least one web link to list beneath it.

Please provide any relevant error logs

No response

@sruenwg sruenwg added the bug Something isn't working label Feb 17, 2024
@sruenwg sruenwg changed the title πŸ› BUG: Some events show Web Links heading with no web links πŸ› BUG: Some events show Web Links heading with no listed web links Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant