Skip to content

[ISTHMUS] [TPCDS] Fix Concat scalar function support #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hbutani opened this issue Jun 27, 2022 · 0 comments · Fixed by #338
Closed

[ISTHMUS] [TPCDS] Fix Concat scalar function support #69

hbutani opened this issue Jun 27, 2022 · 0 comments · Fixed by #338

Comments

@hbutani
Copy link
Contributor

hbutani commented Jun 27, 2022

For example:

  • q5 has the expression: 'web_site' || web_site_id as id
  • q66 has the expression: 'DHL' || ',' || 'BARIAN' as ship_carriers
  • q80 has expression using ||

Implicit casting is not

Queries in tpcds having this issue: [5, 66, 80, 84]

How to reproduce:
Add a test to TpcdsQueryNoValidation like this:

@ParameterizedTest
  @ValueSource(ints = {5})
  public void tpcdsQ5(int query) throws Exception {
    testQuery(query);
  }

On fixing, please move the fixed queries from the tpcdsFailure list to the tpcdsSuccess list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant