Skip to content

Commit be74cd8

Browse files
feat: uncomment tests
Address PR feedback Signed-off-by: andrew-coleman <[email protected]>
1 parent 157276e commit be74cd8

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

spark/src/test/scala/io/substrait/spark/TPCHPlan.scala

+11-8
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,11 @@ class TPCHPlan extends TPCHBase with SubstraitPlanTestBase {
5959
assertSqlSubstraitRelRoundTrip(
6060
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
6161
"order by l_shipdate asc, l_discount desc")
62-
// assertSqlSubstraitRelRoundTrip(
63-
// "select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
64-
// "order by l_shipdate asc, l_discount desc limit 100 offset 1000")
65-
// assertSqlSubstraitRelRoundTrip(
66-
// "select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
67-
// "order by l_shipdate asc, l_discount desc limit 100")
68-
// assertSqlSubstraitRelRoundTrip(
69-
// "select l_partkey from lineitem where l_shipdate < date '1998-01-01' limit 100")
62+
assertSqlSubstraitRelRoundTrip(
63+
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
64+
"order by l_shipdate asc, l_discount desc limit 100")
65+
assertSqlSubstraitRelRoundTrip(
66+
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' limit 100")
7067
assertSqlSubstraitRelRoundTrip(
7168
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
7269
"order by l_shipdate asc, l_discount desc nulls first")
@@ -75,6 +72,12 @@ class TPCHPlan extends TPCHBase with SubstraitPlanTestBase {
7572
"order by l_shipdate asc, l_discount desc nulls last")
7673
}
7774

75+
ignore("simpleOffsetClause") { // TODO need to implement the 'offset' clause for this to pass
76+
assertSqlSubstraitRelRoundTrip(
77+
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
78+
"order by l_shipdate asc, l_discount desc limit 100 offset 1000")
79+
}
80+
7881
test("simpleTest") {
7982
val query = "select p_size from part where p_partkey > cast(100 as bigint)"
8083
assertSqlSubstraitRelRoundTrip(query)

0 commit comments

Comments
 (0)