-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't connect to Webradio #32
Comments
Hi!
I'll fix the issues in the next release, thank you for bringing this up! For now you can use this command:
|
It looks like Phiola is trying to overwrite the file every new tag from the stream. I keep getting new files with your command.
And later a file with the command parameter is created
|
Fixed in 2.1-beta2. Now this command:
should work correctly.
Yes, now phiola will create new files only if the tags have been really changed (and not just sent out by server). |
Wow, you're fast.
brings the error message
or
brings
like the first time. |
Got it, thanks! There's one more thing to fix.
This is OK, because phiola won't overwrite your files without your permission. In general, I don't think you need to overwite any files in this case. Either use something like |
The command with this adress fails
|
Oh, this is another issue indeed, and it happens with AAC streams. Will be fixed.
This one will be more difficult. Does it happen every time you try to play this radio stream? I will try to perform thorough testing of phiola on Windows, there might be a global bug somewhere...
You should use |
Fixed in v2.1-beta3:
and
|
Thank you for the fix.
I'm also having trouble redirecting from another program to hide the Console window. Phiola suddenly requires 11..12% CPU instead of <1% without redirection. What could be the reason? |
Or I get this error while recording:
|
Interesting... Can you show the command line so I can try it myself?
I saw this once too (corrupted file name), but couldn't catch it with debug logging. Can you run phiola as UPDATE: I was able to catch this one! No need for you to collect debug logs here. |
I'm using the wxBasic Interpreter. It's a fork of wxWidgets cpp library. But due to the slow development, it never really became known. To be honest, I don't know whether it will be developed further. I've been working with it for almost 20 years now. I have written an internet radio with a database that can be expanded to around 28000 stations and would like to improve the recording function with Phiola. Dim webProcess = New wxProcess()
//webprocess.Redirect()
Dim phiolaPath = "D:\\phiola-2\\phiola.exe"
Dim out = "D:\\Records\\"
Dim opt = " -vol 0 -tee " &"\"" &out &"@artist - @title.mp3" &"\""
wxExecute(phiolaPath &" " &"http://radiorecord.hostingradio.ru/chil96.aacp" &opt, wxEXEC_ASYNC, webProcess) This should also work in wxwidgets and the CPU usage is below 1%. If I activate "webprocess.Redirect()", then the CPU usage is around 12%. I'm testing the debugging. |
Please open Task Manager and find the process that eats this cpu time. Is it really
Currently phiola doesn't support encoding to MP3. I removed it because I think that everyone should use modern and better audio encoders such as Opus, Vorbis and AAC. Do you really need encoding to MP3 for some reason?
This can be achieved for example by your script if it will read
Actually, I've already caught the bug which causes the crashes. I will fix it in the next release. |
Unfortunately, no error message is displayed when debugging. So it is difficult to see the error. |
@Ducke1001 |
Yes, mp3 is no longer the latest and greatest codec. But I think it is the best known and still the most used. At least for people who aren't that interested in it. That's why I wanted to at least offer a conversion.
Ok, I'll take another look at this.
Thanks for your offer. Yes it is opensource. |
Thank you! I can reproduce this now, it will be fixed. |
and
Both problems are fixed in v2.1-rc4. Should not crash anymore, or at least not that often :) |
Thank you very much. There are no more problems with the redirection now.
But it still happens quite often when playing an aac stream. |
Can you post the command line and the latest crashdump along with the last ~200 lines of debug log? |
Yes, I'll do it. But I'm on vacation right now. I'll have to see when I can get around to it. |
Ok, here is the command line: It is basically the same as before. |
Oh, sorry. The laptop didn't have the latest version. I'll have to try again here. |
So, now with the new version and the old command line: |
I tried to reproduce this on my side, and it works fine for me. OK, first of all, the log file and crashdump do not match. How did you obtain the log file? You should exec phiola like this: Also, does it crash if you play the .aac file that was recorded with Also, how many aac radio streams result in this behaviour? Does it happen only for this particular radio station? |
Yes, I created the command line like this. Ok, here are new logs. This time I deleted everything first.
Hm, strange. When I use your command
I don't notice any crashes and I can play the aac without errors. But with
phiola crashes every few calls.
I tested it with several aac stations. It's always the same result. Anything else. Stream addresses like this cause Phiola to crash.
and with
phiola also crashes if the file already exists. Edit 1: Edit 2: |
Sometimes when I start Phiola with an aac stream under Windows, a WerFault.exe is displayed in the task manager and Phiola is terminated. |
WerFault.exe is a Windows component, it's OK if it is started when any other Windows application crashes. I still haven't been able to reproduce the crash issue you experience. I don't normally use Windows, it requires some special attention... I'll keep you updated on this. |
Hi! I created a new phiola build (with clang and address sanitizer) that I hope can help with the crash issue. It should print some more details in case of failure. Note that I couldn't reproduce the issue on my box. This is the package: (This version will perform somewhat slower due to the enabled address sanitizer.) Please test it. If the issue persists, just post here what it prints. |
Many thanks. I will test it. |
Short interim report: |
Unfortunately the same problem here. Phiola crashes every few times. |
There is no crash dump with this phiola build, because the address sanitizer library takes over - this is perfectly normal. Now we just need to get the stdout and stderr output - I hope we'll see some more info about what's happening. I guess that currently when you run phiola from your code, you just don't collect standard output streams from the child process... Can you run phiola manually from the terminal window and collect the output that is printed to console? |
Oh, sorry. Your message ended up in the spam folder. |
New log: console output: 0:000:01================================================================= AddressSanitizer can not provide additional info. |
Thanks for the info! This message says that libsoxr tries to read from some crazy invalid address, and currently I don't understand where this number may come from. Looks like we'll need to do a couple more iterations to get to the root of this - I'll probably add some more debug logging.
Does this issue happen just on one particular Windows installation? |
No, unfortunately the problem occurs on both systems. |
Hi! I fixed the problem that could cause this crash, can you verify if this build (from branch https://github.com/stsaz/phiola/tree/soxr) works for you? |
Thanks for your work. I will test it on both systems. |
I have tested it many times. Phiola now works most of the time. Since my player sometimes cannot load the address, we can assume that the server is not responding. Phiola is probably very responsive while my player tries to load the address within 15 seconds. Can I adjust the waiting time? Also I get an http error on this adress:
But my player can play the stream. |
Currently the connection timeout is 1 minute, and send/receive timeout is 10 minutes. I can add CLI options to adjust these values - is this what you need?
Should be fixed in v2.2-beta3 |
I didn't know that. Thanks for the info.
Yes, it would be nice to have these options. |
Added in v2.2-rc4:
|
Thank you very much. |
I get an error message for an unknown option with |
Please post the full command and the output. |
Oh man, you're right. Obviously it wasn't copied correctly or I accidentally took the test directory. |
First of all, thank you for your great work.
I tried an example from the description but it fails.
The following command line was entered in the Windows console:
and it ends with an error message
I tried with several addresses. With the same result. But the adresses are valid.
Is this an error in the command or in the program?
The text was updated successfully, but these errors were encountered: