You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
We should be able to merge the Config class and StrykerOptions classes.
They are both quite similar. StrykerOptions has basically the same interface as Config, but optional. We can use awesome ts2.1 mapped type Partial<Config> for this:
We should be able to merge the
Config
class andStrykerOptions
classes.They are both quite similar.
StrykerOptions
has basically the same interface asConfig
, but optional. We can use awesome ts2.1 mapped typePartial<Config>
for this:https://github.com/Microsoft/TypeScript/blob/0a535f0bf7193741e6b4acf5b7dfea88e2d4beca/lib/lib.d.ts#L1379-L1384
One problem is the
set
function. I actually don't like it. Could we get rid of this? Why do we need it? We could make our config simpler:... so no
function(config){ config.set({ ... })}
anymore.I propose to do this in 2 phases.
set
method deprecated. Support both versions of config.@simondel what do you think?
The text was updated successfully, but these errors were encountered: