Upgrade eslint-plugin-react

Author: robertrossmann

coding-styles/react.js

@@ -17,7 +17,8 @@ module.exports = {
     'react/jsx-closing-bracket-location': ['warn', 'line-aligned'],
 
     // Disallow spaces inside of curly braces in JSX attributes
-    'react/jsx-curly-spacing': ['warn', 'never', {
+    'react/jsx-curly-spacing': ['warn', {
+      when: 'never',
       allowMultiline: true,
     }],
 

environments/react/recommended.js

@@ -22,6 +22,9 @@ module.exports = {
     // value. This rule will enforce one or the other to keep consistency in your code.
     'react/jsx-boolean-value': ['warn', 'never'],
 
+    // Enforce the closing tag location for multiline JSX elements
+    'react/jsx-closing-tag-location': ['warn'],
+
     // Restrict file extensions that may contain JSX
     'react/jsx-filename-extension': ['warn', {
       extensions: ['.js', '.jsx'],
@@ -44,6 +47,12 @@ module.exports = {
     // injected as a text node in JSX statements.
     'react/jsx-no-comment-textnodes': 'warn',
 
+    // Enforce all defaultProps have a corresponding non-required PropType
+    // Having defaultProps for non-existent propTypes is likely the result of errors in refactoring
+    // or a sign of a missing propType. Having a defaultProp for a required property similarly
+    // indicates a possible refactoring problem
+    'react/default-props-match-prop-types': 'warn',
+
     // Prevent usage of dangerous JSX properties
     'react/no-danger': 'warn',
 
@@ -124,6 +133,12 @@ module.exports = {
       ignoreStateless: true,
     }],
 
+    // Prevent usage of shouldComponentUpdate when extending React.PureComponent
+    // Warns if you have shouldComponentUpdate defined when defining a component that extends
+    // React.PureComponent. While having shouldComponentUpdate will still work, it becomes pointless
+    // to extend PureComponent.
+    'react/no-redundant-should-component-update': 'warn',
+
     // Prevent usage of the return value of React.render
     // ReactDOM.render() currently returns a reference to the root ReactComponent instance. However,
     // using this return value is legacy and should be avoided because future versions of React may

package-lock.json

@@ -9,7 +9,7 @@
   "contributors": [],
   "dependencies": {
     "eslint-plugin-import": "^2.7.0",
-    "eslint-plugin-react": "^7.0.1"
+    "eslint-plugin-react": "^7.1.0"
   },
   "devDependencies": {
     "eslint": "^4.2.0"