Skip to content

Commit d8782e7

Browse files
committed
Fix accessors and README
Accessors always have a space after them (and usually before), this fix prevents variables like publicKey, protectedKey, etc from being miscolored.
1 parent 68e6023 commit d8782e7

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

README.markdown

+9-8
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
#Smali/Baksmali mode for Emacs#
1+
Smali/Baksmali mode for Emacs
2+
=============================
23

3-
##Overview##
4+
Overview
5+
--------
46
Quickly through this together after seeing all the VIM smali syntax variantions.
57
I couldn't find one for emacs - and well, that's the editor I prefer so I mashed
68
this up. It's probably a really bad hack, but I've never made a mode for emacs,
@@ -10,13 +12,12 @@ smali code much better already.
1012

1113
Enjoy!
1214

13-
Tim Strazzere
14-
15+
1516

1617

1718

18-
##INSTALL##
19-
===
19+
Install
20+
-------
2021
Copy into your .emacs.d file in your home dir, if you don't have one, rename file to ~/.emacs.d
2122
Load up a .smali file and enjoy!
2223

@@ -27,7 +28,7 @@ An example of such code:
2728
(autoload 'smali-mode "smali-mode" "Major mode for editing and viewing smali issues" t)
2829
(add-to-list 'auto-mode-alist '(".smali$" . smali-mode))
2930

30-
##NOTES##
31-
===
31+
Notes
32+
-----
3233
I personally use "//" comments, though these will not recompile in the publicly released
3334
baksmali/smali packages.

SyntaxTest.smali

+4
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
.field public static final S:[[B = null
2121
.field public static final enum NO_FILL:Lcom/google/ads/AdRequest$ErrorCode;
2222

23+
# fields that include access names
24+
.field private privateKey:[B
25+
.field private publicKey:[B
26+
2327
.annotation build Landroid/annotation/SuppressLint;
2428
.annotation runtime Landroid/view/ViewDebug$ExportedProperty;
2529
.annotation system Landroid/view/ViewDebug$ExportedProperty;

smali-mode.el

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
)
130130
;; access
131131
(
132-
"\s\\(public\\|private\\|protected\\|static\\|final\\|synchronized\\|bridge\\|varargs\\|native\s\\|abstract\\|strictfp\\|synthetic\\|constructor\\|declared-synchronized\\|interface\\|enum\\|annotation\\|volatile\\|transient\\)" . font-lock-builtin-face
132+
"\\(public\\|private\\|protected\\|static\\|final\\|synchronized\\|bridge\\|varargs\\|native\\|abstract\\|strictfp\\|synthetic\\|constructor\\|declared-synchronized\\|interface\\|enum\\|annotation\\|volatile\\|transient\\)\s" . font-lock-builtin-face
133133
)
134134
;; random things to color before others function
135135
(

0 commit comments

Comments
 (0)