From 4e06429548f47e54e85aafe6f6b6ba7d41a4ee0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Strausmann?= Date: Sun, 14 Jun 2026 15:04:33 +0000 Subject: [PATCH] refactor(main): _resolve_model_id_from_config nimmt PrinterYAMLConfig statt Any (#67) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Audit #67 / PR #59 Finding: `printer_cfg: Any` in `_resolve_model_id_from_config` verletzt die mypy-strict-policy. Der tatsächliche Typ ist `PrinterYAMLConfig` (aus `app.schemas.printer_config`), wird vom `PrinterConfigLoader.all()` zurückgegeben und im Caller schon typkorrekt iteriert. Fix: Import + Annotation. Verhalten 1:1. mypy ✓ ruff ✓ tests grün (test_lifespan.py 7 passed). Refs #67 Audit-Punkt: "PR #59 — main.py:112,119 _build_backend Any typed" (Die `_build_backend`-Funktion existiert nicht mehr nach Phase 1k.1a; das verbliebene `Any` war in `_resolve_model_id_from_config`.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) --- backend/app/main.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/app/main.py b/backend/app/main.py index 9acc211..99f8f0f 100644 --- a/backend/app/main.py +++ b/backend/app/main.py @@ -101,6 +101,7 @@ from app.printer_backends.exceptions import SnmpDiscoveryError from app.printer_backends.snmp_helper import query_model_pjl from app.printer_models.registry import ModelRegistry +from app.schemas.printer_config import PrinterYAMLConfig from app.schemas.readiness import ReadinessResponse from app.services.backend_router import BackendRouter from app.services.cleanup_task import CleanupTask @@ -182,7 +183,7 @@ def _pinned_openapi_schema(app: FastAPI) -> Any: return app.openapi_schema -async def _resolve_model_id_from_config(printer_cfg: Any) -> str: +async def _resolve_model_id_from_config(printer_cfg: PrinterYAMLConfig) -> str: """SNMP discovery first, fall back to printer_cfg.model on failure. Phase 1i CA-1: ersetzt _resolve_model_id(settings, host) — liest SNMP-