Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Allow Ref<string> for storyblok url in useAsyncStoryblok #546

Open
1 task done
TheAlexLichter opened this issue Aug 29, 2023 · 0 comments
Open
1 task done

Suggestion: Allow Ref<string> for storyblok url in useAsyncStoryblok #546

TheAlexLichter opened this issue Aug 29, 2023 · 0 comments
Assignees
@Dawntraoz
Labels
dx [Issue] Improvement or fix with impact on the developer experience. enhancement [Issue][PR] New feature improvement [Issue][PR] Refactor or code improvement

Comments

@TheAlexLichter
Copy link

Description

Hey 👋🏻

Right now, useAsyncStoryblok is not capable of taking a reactive reference (ref) but only normal strings. As most composables allow using reactive values and deal with them - say e.g. the route/url updates, then the composable refetches. I think it'd be a great addition for the StoryblokSDK

Suggested solution or improvement

Allow refs to be passed and let the composable handle changes by watching and (re-)fetching the content.

Additional context

No response

Validations
@TheAlexLichter TheAlexLichter added enhancement [Issue][PR] New feature pending-author [Issue] Awaiting further information or action from the issue author pending-triage [Issue] Ticket is pending to be prioritised labels Aug 29, 2023
@Dawntraoz Dawntraoz added improvement [Issue][PR] Refactor or code improvement dx [Issue] Improvement or fix with impact on the developer experience. and removed pending-triage [Issue] Ticket is pending to be prioritised labels Mar 5, 2024
@Dawntraoz Dawntraoz self-assigned this Mar 5, 2024
@Dawntraoz Dawntraoz removed the pending-author [Issue] Awaiting further information or action from the issue author label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dawntraoz Dawntraoz

Labels
dx [Issue] Improvement or fix with impact on the developer experience. enhancement [Issue][PR] New feature improvement [Issue][PR] Refactor or code improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheAlexLichter @Dawntraoz