Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Logout succeeds without token revocation #605

Open
sshymko opened this issue Mar 1, 2017 · 0 comments
Open

Logout succeeds without token revocation #605

sshymko opened this issue Mar 1, 2017 · 0 comments

Comments

@sshymko
Copy link

sshymko commented Mar 1, 2017

Built-in endpoint /logout returns successful 200 OK status even when no tokens (access and/or refresh) have been revoked. That can happen when no tokens have been passed as part of a request as they're not required.

This behavior opens the door for mistakes in a client application that can easily go unnoticed because the "logout" appears to succeed.

The expected behavior would be to require passing access token. The call should succeed upon invalidation of a known token only.

Refresh token being optional allows to mistakenly omit it in the request as well. That can easily happen due to the domain/path scope of cookies. In this case the "logout" will be misinterpreted as successful even though the refresh token remains valid.

@sshymko sshymko changed the title Logout succeeds when no token revocation happens Logout succeeds without token revocation Mar 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant