File tree Expand file tree Collapse file tree 3 files changed +11
-11
lines changed Expand file tree Collapse file tree 3 files changed +11
-11
lines changed Original file line number Diff line number Diff line change @@ -18,6 +18,3 @@ const requireIndex = require('requireindex');
18
18
19
19
// import all rules in lib/rules
20
20
module . exports . rules = requireIndex ( __dirname + '/rules' ) ;
21
-
22
-
23
-
Original file line number Diff line number Diff line change @@ -38,16 +38,19 @@ module.exports = {
38
38
const dependencies = node . arguments [ 1 ] ;
39
39
40
40
if ( dependencies && dependencies . type === 'ArrayExpression' && dependencies . elements . length > 1 ) {
41
+ const currentNames = dependencies . elements . map ( item => item . name ) ;
41
42
const sorted = [ ...dependencies . elements ] . sort ( ( a , b ) => ( a . name < b . name ? - 1 : 1 ) ) ;
42
43
const sortedNames = sorted . map ( ( dep ) => dep . name ) ;
43
44
44
- context . report ( {
45
- node,
46
- message : 'Sorting dependencies' ,
47
- fix : function ( fixer ) {
48
- return fixer . replaceText ( dependencies , `[${ sortedNames } ]` ) ;
49
- }
50
- } ) ;
45
+ if ( String ( currentNames ) !== String ( sortedNames ) ) {
46
+ context . report ( {
47
+ node,
48
+ message : 'Sorting dependencies' ,
49
+ fix : function ( fixer ) {
50
+ return fixer . replaceText ( dependencies , `[${ sortedNames } ]` ) ;
51
+ }
52
+ } ) ;
53
+ }
51
54
}
52
55
}
53
56
}
Original file line number Diff line number Diff line change 1
1
{
2
2
"name" : " eslint-plugin-sort-react-dependency-arrays" ,
3
3
"description" : " ESLint plugin to alphabetically sort React hook dependency arrays" ,
4
- "version" : " 0.0.1 " ,
4
+ "version" : " 0.0.2 " ,
5
5
"author" :
" Steven Sacks <[email protected] >" ,
6
6
"keywords" : [
7
7
" eslint" ,
You can’t perform that action at this time.
0 commit comments