Skip to content

Conversation

@eeeXun
Copy link

@eeeXun eeeXun commented Nov 1, 2025

We should get icons from symbol_map

@github-actions github-actions bot requested a review from stevearc November 1, 2025 12:02
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at lspkind and it still looks like it provides the lspkind.symbolic API to retrieve a symbol. Is there some reason why accessing symbol_map is better? Is the symbolic() API not working for you?

@eeeXun
Copy link
Author

eeeXun commented Nov 3, 2025

  1. in this line. There is no mode "symbolic ". "symbolic " is not in modes. So in our current code, we will call modes["symbol"].

  2. In modes["symbol"], it calls get_symbol(), and get_symbol() just returns lspkind.symbol_map.

Is the symbolic() API not working for you?

Yes, it works. But it works by coincidence.

Is there some reason why accessing symbol_map is better?

Yes, we don't need that recursive call.

BTW, the main reason of this PR is nvim-cmp separates icons and kind. So we no longer need symbolic() in lspkind. (I'm also planing create a PR here). And these changes will break this plugin. So, that's why I create this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants