Skip to content

Commit 593e5af

Browse files
authored
Merge pull request #131 from stepstone-tech/develop
3.2.3 release from develop
2 parents 5d3f467 + b4c9b6f commit 593e5af

25 files changed

+596
-534
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
language: android
22
jdk: oraclejdk8
3-
sudo: false
3+
sudo: true
44

55
env:
66
global:

README.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ Moreover, you can find there other examples, e.g. how to persist state on rotati
3030
- [StepperLayout attributes](#stepperlayout-attributes)
3131
- [View attributes](#view-attributes)
3232
- [StepperLayout style attributes](#stepperlayout-style-attributes)
33+
- [Contributing](#contributing)
3334
- [License](#license)
3435

3536
## Supported steppers
@@ -56,7 +57,7 @@ Moreover, you can find there other examples, e.g. how to persist state on rotati
5657

5758
### Download (from JCenter)
5859
```groovy
59-
compile 'com.stepstone.stepper:material-stepper:3.2.2'
60+
compile 'com.stepstone.stepper:material-stepper:3.2.3'
6061
```
6162

6263
### Create layout in XML
@@ -68,7 +69,6 @@ compile 'com.stepstone.stepper:material-stepper:3.2.2'
6869
android:id="@+id/stepperLayout"
6970
android:layout_width="match_parent"
7071
android:layout_height="match_parent"
71-
android:orientation="vertical"
7272
app:ms_stepperType="progress_bar" />
7373
```
7474

@@ -487,6 +487,16 @@ A list of `ms_stepperLayoutTheme` attributes responsible for styling of StepperL
487487
| *ms_stepTabIconBackgroundStyle* | Used by ms_stepIconBackground in layout/ms_step_tab |
488488
| *ms_stepTabTitleStyle* | Used by ms_stepTitle in layout/ms_step_tab |
489489
| *ms_stepTabDividerStyle* | Used by ms_stepDivider in layout/ms_step_tab |
490+
491+
492+
## Contributing
493+
All contributions are welcome and encouraged!
494+
495+
Pull requests should be merged to the ```develop``` branch (Rebase & merge preferred).
496+
Once ```develop``` is stable and we're ready to release the next version
497+
it should be merged to ```master```. Next, a new version should be
498+
uploaded to Bintray and a new release should be created on GitHub.
499+
Library releases should be made from the ```master``` branch.
490500
491501
## License
492502
Copyright 2016 StepStone Services

build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ buildscript {
1818
allprojects {
1919
repositories {
2020
jcenter()
21+
mavenCentral()
2122
}
2223
}
2324

@@ -31,7 +32,8 @@ configure(allprojects) {
3132
androidSupportLibraryVersion = '25.3.1'
3233

3334
junitVersion = '4.12'
34-
mockitoVersion = '1.10.19'
35+
mockitoVersion = '2.7.21'
36+
mockitoKotlinVersion = '1.4.0'
3537
robolectricVersion = '3.3.1'
3638
assertjVersion = '1.1.1'
3739

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@
1919

2020
POM_GROUP_ID=com.stepstone.stepper
2121
POM_ARTIFACT_ID=material-stepper
22-
POM_VERSION=3.2.2
22+
POM_VERSION=3.2.3

material-stepper/build.gradle

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
apply plugin: 'com.android.library'
2+
apply plugin: 'kotlin-android'
23
apply plugin: 'maven'
34
apply from: '../material-stepper/code_coverage.gradle'
45
apply from: '../config/quality/quality.gradle'
@@ -29,7 +30,7 @@ ext {
2930

3031
android {
3132
compileSdkVersion project.androidCompileSdkVersion
32-
buildToolsVersion ("$androidBuildToolsVersion")
33+
buildToolsVersion("$androidBuildToolsVersion")
3334

3435
defaultConfig {
3536
minSdkVersion project.androidMinSdkVersion
@@ -59,15 +60,18 @@ android {
5960
}
6061

6162
dependencies {
62-
compile ("com.android.support:appcompat-v7:$androidSupportLibraryVersion")
63+
compile "com.android.support:appcompat-v7:$androidSupportLibraryVersion"
6364

64-
testCompile("junit:junit:$junitVersion")
65-
testCompile("org.mockito:mockito-core:$mockitoVersion")
66-
testCompile("com.squareup.assertj:assertj-android:$assertjVersion")
65+
testCompile "junit:junit:$junitVersion"
66+
testCompile "org.mockito:mockito-core:$mockitoVersion"
67+
testCompile "com.squareup.assertj:assertj-android:$assertjVersion"
6768
testCompile("org.robolectric:robolectric:$robolectricVersion") {
6869
exclude group: 'commons-logging', module: 'commons-logging'
6970
exclude group: 'org.apache.httpcomponents', module: 'httpclient'
7071
}
72+
testCompile "org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlinVersion"
73+
testCompile "org.jetbrains.kotlin:kotlin-reflect:$kotlinVersion"
74+
testCompile "com.nhaarman:mockito-kotlin:$mockitoKotlinVersion"
7175
}
7276

7377
gradle.taskGraph.beforeTask { Task task ->
@@ -81,7 +85,7 @@ gradle.taskGraph.beforeTask { Task task ->
8185
}
8286

8387
// Log out test results to console
84-
tasks.matching {it instanceof Test}.all {
88+
tasks.matching { it instanceof Test }.all {
8589
testLogging.events = ["failed", "passed", "skipped"]
8690
}
8791

material-stepper/src/main/java/com/stepstone/stepper/StepperLayout.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ public void setAdapter(@NonNull StepAdapter stepAdapter) {
320320
mPager.getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
321321
@Override
322322
public void onGlobalLayout() {
323+
//noinspection deprecation
323324
mPager.getViewTreeObserver().removeGlobalOnLayoutListener(this);
324325
onUpdate(mCurrentStepPosition, false);
325326
}

material-stepper/src/test/java/com/stepstone/stepper/StepperLayoutSanityTest.java

Lines changed: 0 additions & 223 deletions
This file was deleted.

0 commit comments

Comments
 (0)