Skip to content

Commit 962372f

Browse files
chore(test): remove the karma / browserstack test infrastructure (#5600)
We no longer want to run the workflow nor do we want this code hanging around! Now that #5458 is closed we don't need to run the karma tests anymore. STENCIL-1239
1 parent 95e59bd commit 962372f

23 files changed

+11
-13285
lines changed

Diff for: .github/workflows/README.md

+1-12
Original file line numberDiff line numberDiff line change
@@ -117,18 +117,7 @@ When a `git push` is made to a branch, Stencil's CI is designed to stop existing
117117
branch.
118118
A new CI run (of each workflow) will begin upon stopping the existing job(s) using the new `HEAD` of the branch.
119119

120-
### BrowserStack (`browserstack.yml`)
121-
122-
This workflow is used to run a series of integration tests using [BrowserStack](https://www.browserstack.com).
123-
The exact details of which browsers are targeted can be found in the [karma directory](../../test/karma) of the project.
124-
125-
Running this workflow requires a username + access key in order to access BrowserStack.
126-
These credentials are stored as secrets in GitHub.
127-
128-
This workflow differs from most in that it is designed to run on `pull_request_target` triggers.
129-
This allows community provided pull requests to run BrowserStack tests.
130-
131120
## Repository Configuration
132121

133122
Each of the workflows described in the [workflows section](#workflows) of this document must be configured in the
134-
Stencil GitHub repository to be _required_ to pass in order to land code in the `main` branch.
123+
Stencil GitHub repository to be _required_ to pass in order to land code in the `main` branch.

Diff for: .github/workflows/test-browserstack.yml

-108
This file was deleted.

Diff for: .github/workflows/test-wdio.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ jobs:
2121
- name: Checkout Code
2222
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
2323

24-
- name: Use Node Version from Volta (Karma)
24+
- name: Use Node Version from Volta
2525
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
2626
with:
2727
# pull the version to use from the volta key in package.json
28-
node-version-file: './test/karma/package.json'
28+
node-version-file: './test/wdio/package.json'
2929
cache: 'npm'
3030

3131
- name: Install dependencies

Diff for: .prettierignore

-3
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ node_modules/
3434
coverage/
3535

3636
# output from compiling Stencil projects for testing purposes
37-
test/karma/test-sibling/
38-
test/karma/tmp-compiled-tests/
3937
test/**/dist/
4038
test/**/dist-react/
4139
test/**/hydrate/
@@ -49,7 +47,6 @@ test/docs-json/docs.d.ts
4947
test/docs-json/docs.json
5048

5149
# minified angular that exists in the test directory
52-
test/karma/test-app/assets/angular.min.js
5350

5451
# generated screenshot files
5552
/screenshot/index.js

Diff for: .vscode/launch.json

-23
Original file line numberDiff line numberDiff line change
@@ -255,29 +255,6 @@
255255
"${workspaceFolder}/../ionic-docs/stencil.config.ts"
256256
],
257257
"protocol": "inspector"
258-
},
259-
{
260-
"type": "node",
261-
"request": "launch",
262-
"name": "Karma",
263-
"args": [
264-
"${workspaceFolder}/bin/stencil",
265-
"build",
266-
"--max-workers=0",
267-
"--dev",
268-
"--config",
269-
"${workspaceFolder}/test/karma/stencil.config.ts"
270-
],
271-
"protocol": "inspector"
272-
},
273-
{
274-
"type": "node",
275-
"request": "launch",
276-
"name": "Karma Prerender",
277-
"args": [
278-
"${workspaceFolder}/test/karma/test-prerender/prerender.js"
279-
],
280-
"protocol": "inspector"
281258
}
282259
]
283260
}

Diff for: package.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,9 @@
4646
"test.dist": "node scripts/build --validate-build",
4747
"test.end-to-end": "cd test/end-to-end && npm ci && npm test && npm run test.dist",
4848
"test.jest": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js",
49-
"test.karma": "cd test/karma && npm ci && npm run karma",
50-
"test.karma.prod": "cd test/karma && npm ci && npm run karma.prod",
5149
"test.wdio": "cd test/wdio && npm ci && npm run test",
5250
"test.wdio.testOnly": "cd test/wdio && npm ci && npm run wdio",
53-
"test.prod": "npm run test.dist && npm run test.end-to-end && npm run test.jest && npm run test.karma && npm run test.sys.node && npm run test.testing && npm run test.analysis",
51+
"test.prod": "npm run test.dist && npm run test.end-to-end && npm run test.jest && npm run test.wdio && npm run test.sys.node && npm run test.testing && npm run test.analysis",
5452
"test.testing": "node scripts/test/validate-testing.js",
5553
"test.watch": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js --watch",
5654
"test.watch-all": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js --watchAll --coverage",

Diff for: readme.md

+1-4
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,4 @@ In many cases, Stencil can be used as a drop in replacement for traditional fron
9191

9292
Thanks for your interest in contributing!
9393
Please take a moment to read up on our guidelines for [contributing](https://github.com/ionic-team/stencil/blob/main/CONTRIBUTING.md).
94-
Please note that this project is released with a [Contributor Code of Conduct](https://github.com/ionic-team/stencil/blob/main/CODE_OF_CONDUCT.md). By participating in this project you agree to abide by its terms.
95-
96-
### Thanks
97-
Stencil's internal testing suite is supported by the [BrowserStack Open-Source Program](https://www.browserstack.com/open-source)
94+
Please note that this project is released with a [Contributor Code of Conduct](https://github.com/ionic-team/stencil/blob/main/CODE_OF_CONDUCT.md). By participating in this project you agree to abide by its terms.

Diff for: renovate.json5

+4-18
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,6 @@
9999
matchPackageNames: ['@types/jest', 'jest'],
100100
allowedVersions: '<=29'
101101
},
102-
{
103-
// We intentionally run the karma tests against the oldest LTS of Node we support.
104-
// Prevent renovate from trying to bump node
105-
matchFileNames: ['test/karma/package.json'],
106-
matchDepNames: ['node'],
107-
allowedVersions: '<=16'
108-
},
109102
{
110103
// We intentionally run the WebdriverIO tests against the oldest LTS of Node we support.
111104
// Prevent renovate from trying to bump node
@@ -114,27 +107,20 @@
114107
allowedVersions: '<=16'
115108
},
116109
{
117-
// We intentionally run the karma tests against the oldest LTS of Node we support.
110+
// We intentionally run the WebdriverIO tests against the oldest LTS of Node we support.
118111
// Prevent renovate from trying to bump node
119-
matchFileNames: ['test/karma/package.json'],
112+
matchFileNames: ['test/wdio/package.json'],
120113
matchPackageNames: ['@types/node'],
121114
allowedVersions: '<=16'
122115
},
123116
{
124-
// We intentionally run the karma tests against the oldest LTS of Node we support.
117+
// We intentionally run the WebdriverIO tests against the oldest LTS of Node we support.
125118
// Prevent renovate from trying to bump npm and keep it in sync with a version that's supported by the version of
126119
// Node we run against.
127-
matchFileNames: ['test/karma/package.json'],
120+
matchFileNames: ['test/wdio/package.json'],
128121
matchDepNames: ['npm'],
129122
allowedVersions: '<=8'
130123
},
131-
{
132-
// We intentionally run the karma tests against TypeScript v5.2 as an attempt to update has failed
133-
// due to incompatibilities with `karma-typescript`. Prevent renovate from trying to bump TypeScript.
134-
matchFileNames: ['test/karma/package.json'],
135-
matchDepNames: ['typescript'],
136-
allowedVersions: '<5.3'
137-
},
138124
{
139125
matchPackageNames: ['rollup'],
140126
matchPackagePrefixes: ['@rollup'],

Diff for: test/karma/.gitignore

-2
This file was deleted.

Diff for: test/karma/README.md

-116
This file was deleted.

Diff for: test/karma/constants.js

-10
This file was deleted.

0 commit comments

Comments
 (0)