add guide for extending a contract instance's ttl #1030
Conversation
|
Hey @Mackenzie-OO7! Thanks for your contribution here! The SDF team is currently at a conference so we're a little behind on reviewing PRs but we will get to it when the conference is over. |
No problem! |
There was a problem hiding this comment.
Hey, there @Mackenzie-OO7! Thanks for this PR!
There is some conceptual overlap between the page you've written, and an existing page. That one, though, is more focused on how to accomplish this in JavaScript, whereas yours is more "ingrained" in the smart contract itself.
I think it could make sense to combine these into a single page. Maybe that page ends up using the <CodeExample /> component perhaps? That way, you wouldn't have to double-up so much on the conceptual/informational stuff. Whether or not the content actually belongs in the currently published page's location (contract conventions) or here (state archival), I'm not exactly sure, and I think it might even go either way.
What do you think? Is there a way you might be able to weave these two guides together into one?
Thanks for reviewing! I think I can do that😅 |
Mackenzie-OO7
force-pushed
the
guide-for-extending-ttl
branch
from
2fb50ba to
479cc1d
Compare
|
Hi @Mackenzie-OO7! Just checking in here! Were you able to implement @ElliotFriend's feedback and is this ready for re-review? |
hi! i was. it's ready for re-review now. thank you |
|
Great! We're coming up on a holiday in the US so we'll probably do final review next week. Thank you so much! |
No problem. Happy Thanksgiving! |
|
Thank you @Mackenzie-OO7! Let's take the award conversation back to the corresponding issue! |
Thank you too for reviewing! |
closes #616