Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code blocks on RPC getLedgerEntries page are confusing #1385

Closed
leighmcculloch opened this issue Mar 9, 2025 · 2 comments · Fixed by #1429
Closed

Code blocks on RPC getLedgerEntries page are confusing #1385

leighmcculloch opened this issue Mar 9, 2025 · 2 comments · Fixed by #1429
Assignees
Labels
bug Something isn't working rpc-sdk-scrum

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Mar 9, 2025

Some code blocks on the getLedgerEntries RPC have no context as to which SDK they're using:

Screenshot 2025-03-08 at 10 34 38 pm

And some code examples start with Python, then continue with JS/TS, where the first code sample is labeled as Python because of the tab, then the second one is JS/TS and the two depend on each other which isn't possible because the JS can't call the Python:

Screen.Recording.2025-03-08.at.10.30.21.pm.mp4

Originally posted by @leighmcculloch in #1060 (comment)

cc @Shaptic

@leighmcculloch
Copy link
Member Author

This issue was closed by #1429, but the code blocks are still confusing, because there's a multi-part example that starts with python, and then transitions to TypeScript, showing the TypeScript code calling the Python code.

Worth adding the remaining Python examples I think?

@Shaptic
Copy link
Contributor

Shaptic commented Mar 17, 2025

Agreed, opened #1431 to cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc-sdk-scrum
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants