Remove old asserts

Author: marta-lokhova

src/bucket/BucketListSnapshot.cpp

@@ -263,7 +263,7 @@ SearchableBucketListSnapshot::loadPoolShareTrustLinesByAccountAndAsset(
     ZoneScoped;
 
     // This query should only be called during TX apply
-    releaseAssert(threadIsMain());
+    // releaseAssert(threadIsMain());
     mSnapshotManager.maybeUpdateSnapshot(mSnapshot, mHistoricalSnapshots);
     releaseAssert(mSnapshot);
 

src/bucket/BucketManagerImpl.cpp

@@ -1020,7 +1020,7 @@ void
 BucketManagerImpl::startBackgroundEvictionScan(uint32_t ledgerSeq,
                                                bool callFromLedgerClose)
 {
-    releaseAssert(!threadIsMain() || !mConfig.parallelLedgerClose());
+    // releaseAssert(!threadIsMain() || !mConfig.parallelLedgerClose());
     releaseAssert(mConfig.isUsingBucketListDB());
     releaseAssert(mSnapshotManager);
     releaseAssert(!mEvictionFuture.valid());
@@ -1052,7 +1052,6 @@ BucketManagerImpl::resolveBackgroundEvictionScan(
     LedgerKeySet const& modifiedKeys, SorobanNetworkConfig& networkConfig)
 {
     ZoneScoped;
-    releaseAssert(!threadIsMain() || !mConfig.parallelLedgerClose());
     releaseAssert(mEvictionStatistics);
 
     if (!mEvictionFuture.valid())

src/bucket/BucketSnapshotManager.cpp

@@ -45,7 +45,7 @@ BucketSnapshotManager::recordBulkLoadMetrics(std::string const& label,
 {
     // For now, only keep metrics for the main thread. We can decide on what
     // metrics make sense when more background services are added later.
-    releaseAssert(threadIsMain());
+    // releaseAssert(threadIsMain());
 
     if (numEntries != 0)
     {

src/herder/TxSetFrame.cpp

@@ -775,12 +775,6 @@ ApplicableTxSetFrame::ApplicableTxSetFrame(Application& app, bool isGeneralized,
     , mPhaseInclusionFeeMap(mTxPhases.size())
     , mContentsHash(contentsHash)
 {
-    // print hashes
-    CLOG_INFO(Herder, "Creating ApplicableTxSetFrame from txs: {}",
-              hexAbbrev(previousLedgerHash));
-    CLOG_INFO(
-        Herder, "ApplicableTxSetFrame contents hash: {}",
-        hexAbbrev(app.getLedgerManager().getLastClosedLedgerHeader().hash));
     releaseAssert(previousLedgerHash ==
                   app.getLedgerManager().getLastClosedLedgerHeader().hash);
 }