Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore how to make creating a new RPC Client more flexible #17

Open
elizabethengelman opened this issue Oct 7, 2024 · 0 comments
Open

Comments

@elizabethengelman
Copy link
Contributor

While implementing stellar/stellar-cli#1583 (CLI should support rpc providers which require an API key) we discovered that we needed to rework how we're creating new rpc clients so that we could allow users to pass in custom HTTP headers. The change made as part of #1583 is not very flexible if a user needs to change more than just the headers.

We should design a more flexible way to create rpc clients that allow for more customization. A couple of suggestions were:

  • use the builder pattern
  • allow a user to pass in an HttpClient

Based on these discussions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant