Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle ledger UNKNOWN error message #1212

Closed
janewang opened this issue Dec 20, 2024 · 1 comment · Fixed by #1220
Closed

Better handle ledger UNKNOWN error message #1212

janewang opened this issue Dec 20, 2024 · 1 comment · Fixed by #1220
Assignees
@quietbits

Comments

@janewang
Copy link
Contributor

What problem does your feature solve?

User encounters this error when Ledger's stellar app is not opened.
Image

Here's the description of the error from ledger website: https://support.ledger.com/article/11190934937117-zd

We need a better, more usage message for the user.
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Dec 20, 2024
@janewang janewang moved this from Backlog (Not Ready) to Backlog (Ready for Design) in DevX Dec 20, 2024
@janewang janewang assigned quietbits and unassigned sdfcharles Jan 6, 2025
@janewang janewang moved this from Backlog (Ready for Design) to Todo (Ready for Dev) in DevX Jan 6, 2025
@quietbits quietbits moved this from Todo (Ready for Dev) to In Progress in DevX Jan 7, 2025
@quietbits quietbits linked a pull request Jan 7, 2025 that will close this issue
Sign with Ledger: Better error message when app not selected #1220
Merged
@quietbits quietbits moved this from In Progress to Needs Review in DevX Jan 7, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in DevX Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quietbits quietbits

Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sign with Ledger: Better error message when app not selected stellar/laboratory
4 participants
@janewang @quietbits @sdfcharles and others