-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory Iteration and Recursion #69
Comments
It looks like this is your first issue here – welcome! Please familiarize yourself with the contributing guidelines, if you haven't already. |
Thanks for reaching out, @EmilianoJordan. Am I correct in assuming you don't use
In general, I'm not opposed to adding this to the tool itself, as long as it doesn't interfere with using the pre-commit hook. |
I did not know about identify, thanks for that! You are correct, I have not found a pre-commit use case yet. I installed it as a CLI tool for now, and thought that I had a couple use cases for this + what I mentioned. Although I might be able to integrate I'll put something together that doesn't break your pre-commit use case and see what you think. |
Is your feature request related to a problem? Please describe.
For some of my use cases it would be nice to be able to pass arguments/flags to iterate directories or recursively process images. This is, for the most part, for convenience. Most functionality can be done by the caller and and CLI. Python has glob, pathlib etc for accomplishing this from the caller. And the CLI could used something like this
ls -R | grep '.jpeg\|.jpg' | xargs exif-stripper
.But it might still be worth implementing something in this package. I'd be happy to PR a full working example if you're open to that.
Describe the solution you'd like
I have a very rough proposal, The CLI would need updates to support the new function args but this should give an idea.
This does have some issues that will need to be addressed that I know of:
recurse_symlinks: bool = False
but the similarPath().glob()
arg did not get added until python 3.13. I think this functionality should be included in this (>=3.8).Thanks for this package in the first place!
The text was updated successfully, but these errors were encountered: