Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Limit of 20 addresses reached" is not implemented on mobile #22045

Closed
2 tasks
churik opened this issue Feb 10, 2025 · 1 comment · Fixed by #22069
Closed
2 tasks

"Limit of 20 addresses reached" is not implemented on mobile #22045

churik opened this issue Feb 10, 2025 · 1 comment · Fixed by #22069
Assignees
Labels
feature-parity wallet: Save Address All issues related to save address feature wallet-core Issues for mobile wallet team

Comments

@churik
Copy link
Member

churik commented Feb 10, 2025

Bug Report

Problem

As a user, I want to add my saved addresses within the existing backend limits, since exceeding the limit might lead to unexpected behavior.

Found during implementing functional backend tests in status-im/status-go#6333

Discussion: Thread

The backend imposes a limit of 20 addresses, which can be checked using wakuext_remainingCapacityForSavedAddresses.

Currently, this check is not enforced on Mobile, meaning there is effectively no limit, since wakuext_upsertSavedAddress (used for adding/updating saved addresses) does not apply any restrictions.


Expected Behavior

Image

How it is used on desktop client:

if (!d.editMode && root.store.remainingCapacityForSavedAddresses() === 0) {
    limitPopup.active = true
    return
}

Actual Behavior

There is no current behavior, as the screen was not designed for this case.
Could not find it in Figma


Acceptance Criteria

  • Cannot add more than 20 saved addresses per mode
  • See an informative pop-up when the limit is reached - should be toast, design added here

Image

@churik churik added feature-parity wallet-core Issues for mobile wallet team wallet: Save Address All issues related to save address feature labels Feb 10, 2025
@shivekkhurana
Copy link
Contributor

shivekkhurana commented Feb 10, 2025

@xAlisher We'll need some figma design for this ux.

UPD: design added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-parity wallet: Save Address All issues related to save address feature wallet-core Issues for mobile wallet team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants