Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📤 Update sending transaction end point #21480

Closed
shivekkhurana opened this issue Oct 22, 2024 · 2 comments · Fixed by #21541
Closed

📤 Update sending transaction end point #21480

shivekkhurana opened this issue Oct 22, 2024 · 2 comments · Fixed by #21541
Assignees
@alwx
Labels
feature feature requests wallet-core Issues for mobile wallet team
Milestone
2.33.0

Comments

@shivekkhurana
Copy link
Contributor

shivekkhurana commented Oct 22, 2024 •
edited
Loading

Feature Issue

User Story

As a developer,
I want to move to the latest transaction sending RPC
So that

  • Mobile client is in sync with Desktop, to make debugging easier
  • Mobile uses the unified flow for sending txns, which is less error prone and more robust

Description

The PR [1] unifies the transaction flow as defined in Issue [2]. Desktop PR [3] integrates the changes in [1] to Desktop client.

[1] Status-Go Pr: status-im/status-go#5807
[2] Status-Desktop Integration Issue: status-im/status-desktop#16335
[3] Status-Desktop Integration PR: status-im/status-desktop#16330

This migration is good-to-have before we start integrating sign-with-keycard flows.

Acceptance Criteria

Notes
@shivekkhurana shivekkhurana added the feature feature requests label Oct 22, 2024
@shivekkhurana shivekkhurana added the wallet-core Issues for mobile wallet team label Oct 22, 2024
@shivekkhurana shivekkhurana added this to the 2.32.0 Beta milestone Oct 23, 2024
@alwx alwx moved this to In Progress in Status Desktop/Mobile Board Oct 25, 2024
@alwx alwx mentioned this issue Nov 6, 2024
Merged
12 tasks
alwx added a commit that referenced this issue Nov 28, 2024
@alwx
Update sending transaction end point (#21480) (#21541)
de2b5fb 
* Update sending transaction end point

* Transaction approval

* Fixes

* Fixes

* Fixes

* Fix for issue 3

* Fixes for 2, 4, 7

* Update

* Fixes

* Fixes
@github-project-automation github-project-automation bot moved this from In Progress to Done in Status Desktop/Mobile Board Nov 28, 2024
@pavloburykh
Copy link
Contributor

re-opening this issue as we will log bunch of regression bugs as subissues here

@pavloburykh pavloburykh reopened this Nov 28, 2024
@clauxx clauxx moved this from Done to In Progress in Status Desktop/Mobile Board Nov 29, 2024
@clauxx clauxx moved this from In Progress to Done in Status Desktop/Mobile Board Nov 29, 2024
@clauxx clauxx moved this from Done to In Progress in Status Desktop/Mobile Board Nov 29, 2024
@churik churik modified the milestones: 2.32.0, 2.33.0 Dec 26, 2024
@churik
Copy link
Member

churik commented Feb 17, 2025

I believe we can close this epic and just leave the bug opened; I believe it should be resolved soon with new fee calculation that significantly improved in recent status-go

@churik churik closed this as completed Feb 17, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Status Desktop/Mobile Board Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alwx alwx

Labels
feature feature requests wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.33.0
Development

Successfully merging a pull request may close this issue.

Update sending transaction end point (#21480) status-im/status-mobile
4 participants
@alwx @shivekkhurana @churik @pavloburykh