refactor(emoji): change API to accept hexcodes instead + clean up

This is necessary, because passing the direct UTF emoji made it so that we had to let the OS show the emoji so it could look bad on some OSes.
Plus using the hex makes sure we have control over the size.

This commit also removes the old V1 API because no clients use it anymore.

Author: jrainville

protocol/emoji_reaction.go

@@ -14,9 +14,9 @@ import (
 	"github.com/status-im/status-go/protocol/protobuf"
 )
 
-// There is no foolproof way to validate emojis, but this regex should cover all standard emojis
-// it will also allow some non-emoji unicode characters, but that's not a big issue
-var emojiRegex = regexp.MustCompile("(?:\u00A9|\u00AE|[\u2000-\u3300]|[\U0001F000-\U0001FBFF])")
+// Validates that the emoji string is a valid hex string (used for emojis hexcodes
+// eg: 1f385-1f3fe
+var emojiRegex = regexp.MustCompile("[a-f0-9\\-]+")
 
 // EmojiReaction represents an emoji reaction from a user in the application layer, used for persistence, querying and
 // signaling

protocol/messenger_emoji_reactions.go

@@ -57,8 +57,7 @@ func (m *Messenger) CheckMaxNumberOfEmojiReactionsPerMessage(chatID string, mess
 	return nil
 }
 
-// TODO remove emojiID once the client supports sending custom emojis
-func (m *Messenger) SendEmojiReaction(ctx context.Context, chatID, messageID string, emojiID protobuf.EmojiReaction_Type, emoji string) (*MessengerResponse, error) {
+func (m *Messenger) SendEmojiReaction(ctx context.Context, chatID, messageID string, emoji string) (*MessengerResponse, error) {
 	var response MessengerResponse
 
 	chat, ok := m.allChats.Load(chatID)
@@ -68,10 +67,7 @@ func (m *Messenger) SendEmojiReaction(ctx context.Context, chatID, messageID str
 	clock, _ := chat.NextClockAndTimestamp(m.getTimesource())
 
 	if emoji == "" {
-		emoji = ConvertEmojiIDToString(emojiID)
-		if emoji == "" {
-			return nil, errors.New("invalid emojiID")
-		}
+		return nil, errors.New("no emoji provided")
 	}
 
 	// Validate that the emoji is valid
@@ -89,7 +85,7 @@ func (m *Messenger) SendEmojiReaction(ctx context.Context, chatID, messageID str
 			Clock:     clock,
 			MessageId: messageID,
 			ChatId:    chatID,
-			Type:      emojiID,
+			Type:      protobuf.EmojiReaction_UNKNOWN_EMOJI_REACTION_TYPE,
 			Emoji:     emoji,
 		},
 		LocalChatID: chatID,

services/ext/api.go

@@ -978,14 +978,8 @@ func (api *PublicAPI) RegisteredForPushNotifications() (bool, error) {
 }
 
 // Emoji
-
-func (api *PublicAPI) SendEmojiReaction(ctx context.Context, chatID, messageID string, emojiID protobuf.EmojiReaction_Type) (*protocol.MessengerResponse, error) {
-	return api.service.messenger.SendEmojiReaction(ctx, chatID, messageID, emojiID, "")
-}
-
-// TODO remove SendEmojiReaction and remove the V2 when the client supports sending custom emojis
-func (api *PublicAPI) SendEmojiReactionV2(ctx context.Context, chatID, messageID string, emoji string) (*protocol.MessengerResponse, error) {
-	return api.service.messenger.SendEmojiReaction(ctx, chatID, messageID, protobuf.EmojiReaction_UNKNOWN_EMOJI_REACTION_TYPE, emoji)
+func (api *PublicAPI) SendEmojiReaction(ctx context.Context, chatID, messageID string, emoji string) (*protocol.MessengerResponse, error) {
+	return api.service.messenger.SendEmojiReaction(ctx, chatID, messageID, emoji)
 }
 
 func (api *PublicAPI) SendEmojiReactionRetraction(ctx context.Context, emojiReactionID string) (*protocol.MessengerResponse, error) {