fix(efp): Remove verbose logging and unused loading state from following addresses

Cleans up excessive debug logging and removes unused loading state and cache checks from the following addresses modules and service. Updates the QML views to simplify loading indicators and ensures data is loaded when the user navigates to the following addresses page.

Update status-go submodule to latest commit

Author: caveman-eth

src/app/modules/main/wallet_section/following_addresses/controller.nim

@@ -2,8 +2,6 @@ import io_interface, chronicles
 import app/core/eventemitter
 import app_service/service/following_address/service as following_address_service
 
-const SIGNAL_FOLLOWING_ADDRESSES_UPDATED* = following_address_service.SIGNAL_FOLLOWING_ADDRESSES_UPDATED
-
 logScope:
   topics = "following-addresses-controller"
 
@@ -27,40 +25,15 @@ proc delete*(self: Controller) =
   discard
 
 proc init*(self: Controller) =
-  info "following_addresses controller init() called"
-  try:
-    info "following_addresses subscribing to signal", signal=SIGNAL_FOLLOWING_ADDRESSES_UPDATED
-    self.events.on(SIGNAL_FOLLOWING_ADDRESSES_UPDATED) do(e:Args):
-      let args = following_address_service.FollowingAddressesArgs(e)
-      info "following_addresses received signal", userAddress=args.userAddress, addressCount=args.addresses.len
-      self.delegate.loadFollowingAddresses(args.userAddress)
-    info "following_addresses controller init() completed"
-  except Exception as e:
-    error "following_addresses controller init() failed", msg=e.msg
+  self.events.on(following_address_service.SIGNAL_FOLLOWING_ADDRESSES_UPDATED) do(e:Args):
+    let args = following_address_service.FollowingAddressesArgs(e)
+    self.delegate.loadFollowingAddresses(args.userAddress)
 
 proc getFollowingAddresses*(self: Controller, userAddress: string): seq[following_address_service.FollowingAddressDto] =
-  let addresses = self.followingAddressService.getFollowingAddresses(userAddress)
-  info "controller.getFollowingAddresses called",
-    userAddress = userAddress,
-    resultCount = addresses.len
-  
-  # Log first address for debugging
-  if addresses.len > 0:
-    info "controller.getFollowingAddresses first item",
-      address = addresses[0].address,
-      ensName = addresses[0].ensName,
-      ensNameLength = addresses[0].ensName.len
-  
-  return addresses
+  return self.followingAddressService.getFollowingAddresses(userAddress)
 
 proc fetchFollowingAddresses*(self: Controller, userAddress: string, search: string = "", limit: int = 10, offset: int = 0) =
   self.followingAddressService.fetchFollowingAddresses(userAddress, search, limit, offset)
 
-proc isFollowingAddressesLoading*(self: Controller): bool =
-  return self.followingAddressService.isFollowingAddressesLoading()
-
-proc hasFollowingAddressesCache*(self: Controller): bool =
-  return self.followingAddressService.hasFollowingAddressesCache()
-
 proc getTotalFollowingCount*(self: Controller): int =
   return self.followingAddressService.getTotalFollowingCount()

src/app/modules/main/wallet_section/following_addresses/model.nim

@@ -79,26 +79,13 @@ QtObject:
       result = newQVariant(item.getAvatar())
 
   proc setItems*(self: Model, items: seq[Item]) =
-    info "model.setItems called", itemCount = items.len
-    
-    # Log first few items
-    for i in 0 ..< min(3, items.len):
-      info "model.setItems item details",
-        index = i,
-        address = items[i].getAddress(),
-        ensName = items[i].getEnsName(),
-        ensNameLength = items[i].getEnsName().len,
-        name = items[i].getName()
-    
     self.beginResetModel()
     self.items = items
     self.endResetModel()
     self.countChanged()
 
     for item in items:
         self.itemChanged(item.getAddress())
-    
-    info "model.setItems completed"
 
   proc getItemByAddress*(self: Model, address: string): Item =
     if address.len == 0:

src/app/modules/main/wallet_section/following_addresses/module.nim

@@ -25,33 +25,19 @@ proc newModule*(
   events: EventEmitter,
   followingAddressService: following_address_service.Service,
 ): Module =
-  info "following_addresses newModule called"
   result = Module()
   result.delegate = delegate
   result.view = newView(result)
   result.viewVariant = newQVariant(result.view)
   result.controller = newController(result, events, followingAddressService)
   result.moduleLoaded = false
-  info "following_addresses newModule completed"
 
 method delete*(self: Module) =
   self.viewVariant.delete
   self.view.delete
 
 method loadFollowingAddresses*(self: Module, userAddress: string) =
   let followingAddresses = self.controller.getFollowingAddresses(userAddress)
-  info "loadFollowingAddresses: loading data into view",
-    userAddress = userAddress,
-    addressCount = followingAddresses.len
-  
-  # Log first few items for debugging
-  for i in 0 ..< min(3, followingAddresses.len):
-    info "loadFollowingAddresses: item details",
-      index = i,
-      address = followingAddresses[i].address,
-      ensName = followingAddresses[i].ensName,
-      ensNameLength = followingAddresses[i].ensName.len
-  
   self.view.setItems(
     followingAddresses.map(f => initItem(
       f.address,
@@ -60,26 +46,13 @@ method loadFollowingAddresses*(self: Module, userAddress: string) =
       f.avatar,
     ))
   )
-  info "loadFollowingAddresses: view.setItems completed"
-  
-  # Emit signal to update total count in QML
   self.view.totalFollowingCountChanged()
 
 method load*(self: Module) =
-  info "following_addresses load() called"
   try:
-    info "following_addresses setting root context property"
     singletonInstance.engine.setRootContextProperty("walletSectionFollowingAddresses", self.viewVariant)
-    info "following_addresses root context property set successfully"
-
-    # We'll load following addresses when user navigates to the section
-    info "following_addresses initializing controller"
     self.controller.init()
-    info "following_addresses controller initialized"
-    
-    info "following_addresses loading view"
     self.view.load()
-    info "following_addresses load() completed successfully"
   except Exception as e:
     error "following_addresses load() failed", msg=e.msg
 

src/app/modules/main/wallet_section/module.nim

@@ -373,9 +373,7 @@ method load*(self: Module) =
   self.assetsModule.load()
   info "wallet-section: loading savedAddressesModule"
   self.savedAddressesModule.load()
-  info "wallet-section about to load followingAddressesModule"
   self.followingAddressesModule.load()
-  info "wallet-section followingAddressesModule.load() completed"
   self.buySellCryptoModule.load()
   self.overviewModule.load()
   self.sendModule.load()
@@ -430,13 +428,6 @@ proc checkIfModuleDidLoad(self: Module) =
   self.moduleLoaded = true
   self.delegate.walletSectionDidLoad()
   self.view.setWalletReady()
-  
-  # Lazy pre-fetch EFP following addresses for primary wallet account
-  let walletAccounts = self.controller.getWalletAccounts()
-  if walletAccounts.len > 0:
-    let primaryAccount = walletAccounts[0]  # First account is primary
-    info "Pre-fetching EFP following addresses for primary account", address = primaryAccount.address
-    self.followingAddressesModule.fetchFollowingAddresses(primaryAccount.address)
 
 method viewDidLoad*(self: Module) =
   self.checkIfModuleDidLoad()

src/app_service/service/following_address/service.nim

@@ -18,7 +18,6 @@ logScope:
 
 # Signals which may be emitted by this service:
 const SIGNAL_FOLLOWING_ADDRESSES_UPDATED* = "followingAddressesUpdated"
-const SIGNAL_FOLLOWING_ADDRESSES_ABOUT_TO_BE_UPDATED* = "followingAddressesAboutToBeUpdated"
 
 type
   FollowingAddressesArgs* = ref object of Args
@@ -30,8 +29,6 @@ QtObject:
     threadpool: ThreadPool
     events: EventEmitter
     followingAddressesTable: Table[string, seq[FollowingAddressDto]]
-    followingAddressesLoading: bool
-    hasCacheData: bool
     networkService: network_service.Service
     totalFollowingCount: int
 
@@ -45,8 +42,6 @@ QtObject:
     result.events = events
     result.networkService = networkService
     result.followingAddressesTable = initTable[string, seq[FollowingAddressDto]]()
-    result.followingAddressesLoading = false
-    result.hasCacheData = false
     result.totalFollowingCount = 0
 
   proc init*(self: Service) =
@@ -61,9 +56,6 @@ QtObject:
     return @[]
 
   proc fetchFollowingAddresses*(self: Service, userAddress: string, search: string = "", limit: int = 10, offset: int = 0) =
-    self.followingAddressesLoading = true
-    defer: self.events.emit(SIGNAL_FOLLOWING_ADDRESSES_ABOUT_TO_BE_UPDATED, Args())
-    
     # Fetch stats only when not searching (to get total count for pagination)
     if search.len == 0:
       self.fetchFollowingStats(userAddress)
@@ -80,23 +72,15 @@ QtObject:
     self.threadpool.start(arg)
 
   proc onFollowingAddressesFetched(self: Service, response: string) {.slot.} =
-    info "onFollowingAddressesFetched called", responseLength = response.len
-    self.followingAddressesLoading = false
     try:
       let parsedJson = response.parseJson
-      info "onFollowingAddressesFetched parsed JSON"
 
       var errorString: string
       var userAddress: string
       var followingAddressesJson, followingResult: JsonNode
       discard parsedJson.getProp("followingAddresses", followingAddressesJson)
       discard parsedJson.getProp("userAddress", userAddress)
       discard parsedJson.getProp("error", errorString)
-      
-      info "onFollowingAddressesFetched extracted props", 
-        userAddress = userAddress,
-        hasError = not errorString.isEmptyOrWhitespace,
-        hasFollowingJson = not followingAddressesJson.isNil
 
       if not errorString.isEmptyOrWhitespace:
         error "onFollowingAddressesFetched got error from backend", errorString = errorString
@@ -115,13 +99,8 @@ QtObject:
 
       let addresses = followingResult.getElems().map(proc(x: JsonNode): FollowingAddressDto = x.toFollowingAddressDto())
 
-      info "onFollowingAddressesFetched successfully parsed addresses with ENS data from API", 
-        userAddress = userAddress,
-        addressCount = addresses.len
-      
       # Update cache with complete data (ENS names and avatars already included from API)
       self.followingAddressesTable[userAddress] = addresses
-      self.hasCacheData = true
 
       # Emit signal to refresh UI - data is complete
       let args = FollowingAddressesArgs(userAddress: userAddress, addresses: addresses)
@@ -131,12 +110,6 @@ QtObject:
       error "onFollowingAddressesFetched exception", msg = e.msg, stack = e.getStackTrace()
       self.events.emit(SIGNAL_FOLLOWING_ADDRESSES_UPDATED, Args())
 
-  proc isFollowingAddressesLoading*(self: Service): bool =
-    return self.followingAddressesLoading
-
-  proc hasFollowingAddressesCache*(self: Service): bool =
-    return self.hasCacheData
-
   proc getTotalFollowingCount*(self: Service): int =
     return self.totalFollowingCount
 
@@ -145,7 +118,6 @@ QtObject:
       let response = following_addresses.getFollowingStats(userAddress)
       if response.error.isNil:
         self.totalFollowingCount = response.result.getInt()
-        info "fetchFollowingStats: total count", count = self.totalFollowingCount
       else:
         error "fetchFollowingStats: error", error = response.error
     except Exception as e:

src/backend/backend.nim

@@ -326,6 +326,3 @@ rpc(fetchMarketTokenPageAsync, "wallet"):
 
 rpc(unsubscribeFromLeaderboard, "wallet"):
   discard
-
-rpc(getFollowingAddresses, "wallet"):
-  userAddress: string

ui/app/AppLayouts/Wallet/stores/RootStore.qml

@@ -65,7 +65,6 @@ QtObject {
     }
 
     readonly property var followingAddresses: walletSectionFollowingAddresses ? walletSectionFollowingAddresses.model : null
-    property bool loadingFollowingAddresses: false
 
     function refreshFollowingAddresses(search, limit, offset) {
         if (!walletSectionFollowingAddresses) return

ui/app/AppLayouts/Wallet/views/FollowingAddresses.qml

@@ -88,6 +88,10 @@ Item {
         }
     }
 
+    Component.onCompleted: {
+        d.refresh()  // Load data when user navigates to this page
+    }
+
     Timer {
         id: searchDebounceTimer
         interval: 250
@@ -140,25 +144,18 @@ Item {
             id: noFollowingAddresses
             Layout.fillWidth: true
             Layout.preferredHeight: 44
-            visible: RootStore.followingAddresses.count === 0
+            visible: RootStore.followingAddresses.count === 0 && !d.isPaginationLoading
             text: qsTr("Your EFP onchain friends will appear here")
         }
 
         ShapeRectangle {
             id: emptySearchResult
             Layout.fillWidth: true
             Layout.preferredHeight: 44
-            visible: RootStore.followingAddresses.count > 0 && listView.count === 0
+            visible: RootStore.followingAddresses.count > 0 && listView.count === 0 && !d.isPaginationLoading
             text: qsTr("No following addresses found. Check spelling or address is correct.")
         }
 
-        StatusLoadingIndicator {
-            id: loadingIndicator
-            Layout.alignment: Qt.AlignHCenter
-            visible: RootStore.loadingFollowingAddresses
-            color: Theme.palette.directColor4
-        }
-
         Item {
             visible: noFollowingAddresses.visible || emptySearchResult.visible
             Layout.fillWidth: true

ui/app/AppLayouts/Wallet/views/FollowingAddressesView.qml

@@ -21,14 +21,11 @@ RightTabBaseView {
     property SharedStores.NetworkConnectionStore networkConnectionStore
     required property SharedStores.NetworksStore networksStore
 
-    // Note: Following addresses are pre-fetched when wallet loads,
-    // so data should already be available when user navigates here
-
     header: WalletFollowingAddressesHeader {
         lastReloadedTime: !!root.rootStore.lastReloadTimestamp ?
                               LocaleUtils.formatRelativeTimestamp(
                                   root.rootStore.lastReloadTimestamp * 1000) : ""
-        loading: root.rootStore.isAccountTokensReloading
+        loading: followingAddresses.isPaginationLoading
 
         onReloadRequested: followingAddresses.refresh()
         onAddViaEFPClicked: Global.openLinkWithConfirmation("https://efp.app", "efp.app")