ascending does not sort Booleans

Author: flexatone

src/_arraykit.c

@@ -4885,18 +4885,21 @@ BIIterSelector_new(BlockIndexObject *bi,
             }
         }
         else if (kind == BIIS_SEQ && k != 'i' && k != 'u') {
-            PyErr_SetString(PyExc_TypeError, "Arrays must integer kind");
+            PyErr_SetString(PyExc_TypeError, "Arrays must be integer kind");
             return NULL;
         }
         else if (kind == BIIS_BOOLEAN && k != 'b') {
-            PyErr_SetString(PyExc_TypeError, "Arrays must Boolean kind");
+            PyErr_SetString(PyExc_TypeError, "Arrays must be Boolean kind");
             return NULL;
         }
-        if (kind == BIIS_BOOLEAN && len != bi->bir_count) {
-            PyErr_SetString(PyExc_TypeError, "Boolean arrays must match BlockIndex size");
-            return NULL;
+
+        if (kind == BIIS_BOOLEAN) {
+            if (len != bi->bir_count) {
+                PyErr_SetString(PyExc_TypeError, "Boolean arrays must match BlockIndex size");
+                return NULL;
+            }
         }
-        if (ascending) {
+        else if (ascending) { // not Boolean
             // NOTE: we can overwrite selector here as we have a borrowed refernce; sorting gives us a new reference, so we do not need to incref below
             selector = PyArray_NewCopy(a, NPY_CORDER);
             // sort in-place; can use a non-stable sort

test/test_block_index.py

@@ -761,3 +761,36 @@ def test_block_index_iter_contiguous_g(self) -> None:
 
         with self.assertRaises(TypeError):
             _ = list(bi1.iter_contiguous('a'))
+
+
+    def test_block_index_iter_contiguous_h1(self) -> None:
+        bi1 = BlockIndex()
+        bi1.register(np.arange(6).reshape(2,3))
+        bi1.register(np.arange(6).reshape(2,3))
+
+        sel = np.array([1, 1, 1, 0, 0, 0]).astype(bool)
+        post1 = list(bi1.iter_contiguous(sel))
+        post2 = list(bi1.iter_contiguous(sel, ascending=True))
+        self.assertEqual(post1, post2)
+        self.assertEqual(post1, [(0, slice(0, 3, None))])
+
+    def test_block_index_iter_contiguous_h2(self) -> None:
+        bi1 = BlockIndex()
+        bi1.register(np.arange(6).reshape(2,3))
+        bi1.register(np.arange(6).reshape(2,3))
+
+        sel = np.array([1, 0, 1, 0, 1, 0]).astype(bool)
+        post1 = list(bi1.iter_contiguous(sel))
+        post2 = list(bi1.iter_contiguous(sel, ascending=True))
+        self.assertEqual(post1, post2)
+        self.assertEqual(post1,
+                [(0, slice(0, 1, None)),
+                (0, slice(2, 3, None)),
+                (1, slice(1, 2, None))])
+
+        post3 = list(bi1.iter_contiguous(sel, ascending=True, reduce=True))
+        self.assertEqual(post3,
+                [(0, 0),
+                (0, 2),
+                (1, 1)])
+