Skip to content

Commit 875d027

Browse files
committed
code cleanup
1 parent b63b156 commit 875d027

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/_arraykit.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3770,14 +3770,16 @@ isna_element(PyObject *m, PyObject *args, PyObject *kwargs)
37703770
}
37713771
// Try to identify Pandas Timestamp NATs
37723772
if (PyObject_HasAttrString(element, "to_numpy")) {
3773+
// can we match the class name NaTType?
3774+
37733775
PyObject *to_numpy = PyObject_GetAttrString(element, "to_numpy");
37743776
if (to_numpy == NULL) {
37753777
return NULL;
37763778
}
37773779
if (!PyCallable_Check(to_numpy)) {
3780+
Py_DECREF(to_numpy);
37783781
Py_RETURN_FALSE;
37793782
}
3780-
37813783
PyObject* scalar = PyObject_CallFunction(to_numpy, NULL);
37823784
Py_DECREF(to_numpy);
37833785
if (scalar == NULL) {

test/test_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,13 +355,13 @@ def test_isna_element_d(self) -> None:
355355
self.assertFalse(isna_element(s1))
356356

357357

358-
359358
def test_isna_element_e(self) -> None:
360359
from types import SimpleNamespace
361360
sn = SimpleNamespace()
362361
sn.to_numpy = None
363362
self.assertFalse(isna_element(sn))
364363

364+
365365
#---------------------------------------------------------------------------
366366

367367
def test_dtype_from_element_core_dtypes(self) -> None:

0 commit comments

Comments
 (0)