Skip to content

Commit 4e810c6

Browse files
committed
additional test of lenght hint
1 parent 4334fe6 commit 4e810c6

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/_arraykit.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3644,9 +3644,7 @@ A2DTuple_iternext(A2DTupleObject *self) {
36443644
self->pos++;
36453645
return tuple;
36463646
}
3647-
else {
3648-
return NULL;
3649-
}
3647+
return NULL;
36503648
}
36513649

36523650
// static PyObject *

test/test_util.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,12 +333,23 @@ def test_array2d_tuple_iter_b(self) -> None:
333333
def test_array2d_tuple_iter_c(self) -> None:
334334
a1 = np.array([['aaa', 'bb'], ['c', 'dd'], ['ee', 'fffff']])
335335
it = array2d_tuple_iter(a1)
336+
self.assertEqual(it.__length_hint__(), 3)
336337
self.assertEqual(next(it), ('aaa', 'bb'))
338+
self.assertEqual(it.__length_hint__(), 2)
337339
self.assertEqual(next(it), ('c', 'dd'))
340+
self.assertEqual(it.__length_hint__(), 1)
338341
self.assertEqual(next(it), ('ee', 'fffff'))
342+
self.assertEqual(it.__length_hint__(), 0)
339343
with self.assertRaises(StopIteration):
340344
next(it)
341345

346+
def test_array2d_tuple_iter_d(self) -> None:
347+
a1 = np.array([['aaa', 'bb'], ['c', 'dd'], ['ee', 'fffff']])
348+
it = array2d_tuple_iter(a1)
349+
# __reversed__ not implemented
350+
with self.assertRaises(TypeError):
351+
reversed(it)
352+
342353
#---------------------------------------------------------------------------
343354

344355
def test_isna_element_a(self) -> None:

0 commit comments

Comments
 (0)