Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Opt-in video comments metadata -> details #414

Open
QxxxGit opened this issue Dec 25, 2023 · 2 comments
Open

[Feature] Opt-in video comments metadata -> details #414

QxxxGit opened this issue Dec 25, 2023 · 2 comments
Labels
plugin-idea Feature requests that are better served as a plugin

Comments

@QxxxGit
Copy link
Contributor

QxxxGit commented Dec 25, 2023

I use yt-dlp often, and with the commands --add-metadata and --parse-metadata, I'm able to add the description of a video to the comments field of a video's metadata. It would be nice if Stash would add it to the details field.

I'm pretty confident it used to work this way natively, as I have multiple scenes with their details filled by the comments metadata in their video files. From a little digging, these scenes were created in late 2021 -- so maybe it worked around then and something changed.

In case it could potentially cause conflicts somewhere, it might be ideal to have an opt-in setting.

@DingDongSoLong4
Copy link

This was indeed a feature once, but it was deprecated as it was not ported over during the files refactor (in v0.17).

From stashapp/stash#2743:

  • deprecated useFileMetadata and stripFileExtension scan options. These are probably better suited as scrapers, plugins or scripts.

useFileMetadata was the scan option that enabled the feature you're referring to. I think I agree with the reasoning given for the deprecation - a scraper that pulls from file metadata would be more versatile than something built into the scan task. You'd be able to set metadata at any time, rather than only during the initial scan, for example.

I don't know if someone has already written such a scraper, so you might have to write it yourself. I'm sure there are many python libraries to get every possible kind of metadata out of a video file though, so I don't think it should be too difficult.

@QxxxGit
Copy link
Contributor Author

QxxxGit commented Dec 26, 2023

Thanks for the info. In that case, I'll close this request. I'll consider writing a plugin after thinking on it.

@QxxxGit QxxxGit closed this as completed Dec 26, 2023
@DogmaDragon DogmaDragon transferred this issue from stashapp/stash Aug 21, 2024
@DogmaDragon DogmaDragon added the plugin-idea Feature requests that are better served as a plugin label Aug 21, 2024
@DogmaDragon DogmaDragon reopened this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin-idea Feature requests that are better served as a plugin
Projects
None yet
Development

No branches or pull requests

3 participants