Fix crash in universal builds

stackotter · stackotter · commit 2f84f516cf6b · 2021-12-20T08:24:57.000+10:00
diff --git a/Sources/swift-bundler/Subcommands/Build.swift b/Sources/swift-bundler/Subcommands/Build.swift
@@ -81,9 +81,10 @@ extension Bundler {
       command += " --arch arm64 --arch x86_64"
     }
     let exitStatus = Shell.getExitStatus(command, packageDir, silent: false, lineHandler: { line in
-      if shouldBuildUniversal && line.split(separator: ":")[0].last == "%" {
+      let parts = line.split(separator: ":")
+      if shouldBuildUniversal && !parts.isEmpty && parts[0].last == "%" {
         // The output style changes completely in universal builds for whatever reason :)
-        if let percentage = Double(line.split(separator: ":")[0].dropLast()) {
+        if let percentage = Double(parts[0].dropLast()) {
           updateProgress(line, 0.8 * (percentage / 100) + 0.1, shouldLog: false)
         }
       } else if line.starts(with: "[") {

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,10 @@ extension Bundler {`
`81`	`81`	`command += " --arch arm64 --arch x86_64"`
`82`	`82`	`}`
`83`	`83`	`let exitStatus = Shell.getExitStatus(command, packageDir, silent: false, lineHandler: { line in`
`84`		`- if shouldBuildUniversal && line.split(separator: ":")[0].last == "%" {`
	`84`	`+ let parts = line.split(separator: ":")`
	`85`	`+ if shouldBuildUniversal && !parts.isEmpty && parts[0].last == "%" {`
`85`	`86`	`// The output style changes completely in universal builds for whatever reason :)`
`86`		`- if let percentage = Double(line.split(separator: ":")[0].dropLast()) {`
	`87`	`+ if let percentage = Double(parts[0].dropLast()) {`
`87`	`88`	`updateProgress(line, 0.8 * (percentage / 100) + 0.1, shouldLog: false)`
`88`	`89`	`}`
`89`	`90`	`} else if line.starts(with: "[") {`