Skip to content

Commit 72dc20a

Browse files
authored
add maxUnavailable to utils (#479)
Co-authored-by: Gökçe Gök Klingel <[email protected]>
1 parent 425a9a2 commit 72dc20a

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

internal/pkg/services/ske/utils/utils.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const (
2121
defaultNodepoolMachineType = "b1.2"
2222
defaultNodepoolMachineImageName = "flatcar"
2323
defaultNodepoolMaxSurge = 1
24+
defaultNodepoolMaxUnavailable = 0
2425
defaultNodepoolMaximum = 2
2526
defaultNodepoolMinimum = 1
2627
defaultNodepoolName = "pool-default"
@@ -138,10 +139,11 @@ func getDefaultPayloadNodepool(resp *ske.ProviderOptions) (*ske.Nodepool, error)
138139
Name: utils.Ptr(defaultNodepoolMachineImageName),
139140
},
140141
},
141-
MaxSurge: utils.Ptr(int64(defaultNodepoolMaxSurge)),
142-
Maximum: utils.Ptr(int64(defaultNodepoolMaximum)),
143-
Minimum: utils.Ptr(int64(defaultNodepoolMinimum)),
144-
Name: utils.Ptr(defaultNodepoolName),
142+
MaxSurge: utils.Ptr(int64(defaultNodepoolMaxSurge)),
143+
MaxUnavailable: utils.Ptr(int64(defaultNodepoolMaxUnavailable)),
144+
Maximum: utils.Ptr(int64(defaultNodepoolMaximum)),
145+
Minimum: utils.Ptr(int64(defaultNodepoolMinimum)),
146+
Name: utils.Ptr(defaultNodepoolName),
145147
Volume: &ske.Volume{
146148
Type: utils.Ptr(defaultNodepoolVolumeType),
147149
Size: utils.Ptr(int64(defaultNodepoolVolumeSize)),

internal/pkg/services/ske/utils/utils_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -312,10 +312,11 @@ func fixtureGetDefaultPayload(mods ...func(*ske.CreateOrUpdateClusterPayload)) *
312312
Name: utils.Ptr("flatcar"),
313313
},
314314
},
315-
MaxSurge: utils.Ptr(int64(1)),
316-
Maximum: utils.Ptr(int64(2)),
317-
Minimum: utils.Ptr(int64(1)),
318-
Name: utils.Ptr("pool-default"),
315+
MaxSurge: utils.Ptr(int64(1)),
316+
MaxUnavailable: utils.Ptr(int64(0)),
317+
Maximum: utils.Ptr(int64(2)),
318+
Minimum: utils.Ptr(int64(1)),
319+
Name: utils.Ptr("pool-default"),
319320
Volume: &ske.Volume{
320321
Type: utils.Ptr("storage_premium_perf2"),
321322
Size: utils.Ptr(int64(50)),

0 commit comments

Comments
 (0)