Skip to content

Commit 3ab3f6f

Browse files
authored
fix no credentials listing (#313)
1 parent 05eb3d6 commit 3ab3f6f

File tree

1 file changed

+20
-12
lines changed
  • internal/cmd/load-balancer/observability-credentials/list

1 file changed

+20
-12
lines changed

internal/cmd/load-balancer/observability-credentials/list/list.go

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,21 +83,29 @@ func NewCmd(p *print.Printer) *cobra.Command {
8383
return fmt.Errorf("list Load Balancer observability credentials: %w", err)
8484
}
8585
credentialsPtr := resp.Credentials
86-
if credentialsPtr == nil || len(*credentialsPtr) == 0 {
87-
p.Info("No observability credentials found for Load Balancer on project %q\n", projectLabel)
88-
return nil
89-
}
9086

91-
credentials := *credentialsPtr
92-
93-
filterOp, err := getFilterOp(model.Used, model.Unused)
94-
if err != nil {
95-
return err
87+
var credentials []loadbalancer.CredentialsResponse
88+
if credentialsPtr != nil && len(*credentialsPtr) > 0 {
89+
credentials = *credentialsPtr
90+
filterOp, err := getFilterOp(model.Used, model.Unused)
91+
if err != nil {
92+
return err
93+
}
94+
credentials, err = utils.FilterCredentials(ctx, apiClient, credentials, model.ProjectId, filterOp)
95+
if err != nil {
96+
return fmt.Errorf("filter credentials: %w", err)
97+
}
9698
}
9799

98-
credentials, err = utils.FilterCredentials(ctx, apiClient, credentials, model.ProjectId, filterOp)
99-
if err != nil {
100-
return fmt.Errorf("filter credentials: %w", err)
100+
if len(credentials) == 0 {
101+
opLabel := "No "
102+
if model.Used {
103+
opLabel += "used"
104+
} else if model.Unused {
105+
opLabel += "unused"
106+
}
107+
p.Info("%s observability credentials found for Load Balancer on project %q\n", opLabel, projectLabel)
108+
return nil
101109
}
102110

103111
// Truncate output

0 commit comments

Comments
 (0)