Prisma-handled history; prevent history also on jobs and special items

Author: Soxasora

api/paidAction/itemUpdate.js

@@ -1,4 +1,4 @@
-import { PAID_ACTION_PAYMENT_METHODS, USER_ID } from '@/lib/constants'
+import { PAID_ACTION_PAYMENT_METHODS, USER_ID, ADMIN_ITEMS } from '@/lib/constants'
 import { uploadFees } from '../resolvers/upload'
 import { getItemMentions, getMentions, performBotBehavior } from './lib/item'
 import { notifyItemMention, notifyMention } from '@/lib/webPush'
@@ -65,6 +65,28 @@ export async function perform (args, context) {
     data: { paid: true }
   })
 
+  // history tracking
+  // has to be older than 10 minutes, not a bio, not a job, not deleted, not a special item.
+  const adminItem = ADMIN_ITEMS.includes(old.id)
+  if (old.createdAt < new Date(Date.now() - 10 * 60 * 1000) && !old.bio && old.subName !== 'jobs' && !data.deletedAt && !adminItem) {
+    await tx.oldItem.create({
+      data: {
+        title: old.title,
+        text: old.text,
+        url: old.url,
+        userId: old.userId,
+        subName: old.subName,
+        imgproxyUrls: old.imgproxyUrls,
+        cloneBornAt: old.cloneBornAt,
+        cloneDiedAt: new Date(),
+        originalItemId: parseInt(id)
+      }
+    })
+
+    data.cloneBornAt = new Date()
+    data.cloneDiedAt = null
+  }
+
   // we put boost in the where clause because we don't want to update the boost
   // if it has changed concurrently
   await tx.item.update({

api/typeDefs/item.js

@@ -102,8 +102,6 @@ export default gql`
     imgproxyUrls: JSONObject
     cloneBornAt: Date
     cloneDiedAt: Date
-    uploadId: Int
-    pollCost: Int
     deletedAt: Date
     originalItemId: Int
   }

components/item-history.js

@@ -34,7 +34,6 @@ export default function HistoryDropdown ({ item }) {
         <hr className='dropdown-divider' />
         <Dropdown.Item
           title={lastEdited}
-          // onClick={handleLastEdit}
         >
           edited {timeSince(lastEdited)} ago (most recent)
         </Dropdown.Item>

components/item-info.js

@@ -146,7 +146,7 @@ export default function ItemInfo ({
               yesterday
             </Link>
           </>}
-        {item.oldVersions?.length > 0 && !item.deletedAt &&
+        {item.oldVersions?.length > 0 && !item.deletedAt && // bios, jobs and admin items are not tracked
           <>
             <span> </span>
             <HistoryDropdown item={item} />
@@ -225,7 +225,7 @@ export default function ItemInfo ({
                   <hr className='dropdown-divider' />
                   <PinSubDropdownItem item={item} />
                 </>}
-              {item.mine && sub && !item.deletedAt && !item.bio && // has to have a sub for edit page
+              {item.mine && !item.deletedAt && sub && // has to have a sub for edit page
                 <>
                   <hr className='dropdown-divider' />
                   <Dropdown.Item onClick={() => !item.parentId ? router.push(`/items/${item.id}/edit`) : toggleShadowEdit(true)} className='text-reset dropdown-item'>

fragments/items.js

@@ -87,8 +87,6 @@ export const ITEM_FIELDS = gql`
       imgproxyUrls
       cloneBornAt
       cloneDiedAt
-      uploadId
-      pollCost
       deletedAt
       originalItemId
     }

prisma/migrations/20250217233746_perpetual_edit/migration.sql

@@ -19,8 +19,6 @@ CREATE TABLE "OldItem" (
     "imgproxyUrls" JSONB,
     "cloneBornAt" TIMESTAMP(3),
     "cloneDiedAt" TIMESTAMP(3),
-    "uploadId" INTEGER,
-    "pollCost" INTEGER,
     "deletedAt" TIMESTAMP(3),
     "original_itemId" INTEGER NOT NULL,
 
@@ -38,66 +36,3 @@ CREATE INDEX "OldItem_original_itemId_idx" ON "OldItem"("original_itemId");
 
 -- AddForeignKey
 ALTER TABLE "OldItem" ADD CONSTRAINT "OldItem_original_itemId_fkey" FOREIGN KEY ("original_itemId") REFERENCES "Item"("id") ON DELETE CASCADE ON UPDATE CASCADE;
-
-CREATE OR REPLACE FUNCTION before_item_update()
-RETURNS TRIGGER AS $$
-BEGIN
-    -- history shall be written only if the item is older than 10 minutes and content has changed
-    IF (OLD."created_at" < now() - interval '10 minutes')
-    AND OLD."bio" IS FALSE
-    AND NEW."deletedAt" IS NULL
-    AND (OLD."text" != NEW."text" OR OLD."title" != NEW."title" OR OLD."url" != NEW."url")
-    THEN
-        -- TODO honestly find a better way to do this, I mean this works but it's bad
-        INSERT INTO "OldItem" (
-            "created_at",
-            "updated_at",
-            "title",
-            "text",
-            "url",
-            "userId",
-            "subName",
-            "imgproxyUrls",
-            "cloneBornAt",
-            "cloneDiedAt",
-            "uploadId",
-            "pollCost",
-            "deletedAt",
-            "original_itemId"
-        )
-        VALUES (
-            OLD."created_at",
-            OLD."updated_at",
-            OLD."title",
-            OLD."text",
-            OLD."url",
-            OLD."userId",
-            OLD."subName",
-            OLD."imgproxyUrls",
-            OLD."cloneBornAt",
-            OLD."cloneDiedAt",
-            OLD."uploadId",
-            OLD."pollCost",
-            OLD."deletedAt",
-            OLD."id"
-        );
-        
-        -- item shall die
-        UPDATE "OldItem" 
-        SET "cloneDiedAt" = now()
-        WHERE "original_itemId" = OLD.id 
-        AND "cloneDiedAt" IS NULL;
-
-        -- to be born again
-        NEW."cloneBornAt" = now();
-        NEW."cloneDiedAt" = NULL;
-    END IF;
-
-    RETURN NEW;
-END;
-$$ LANGUAGE plpgsql;
-
-CREATE TRIGGER item_history_trigger
-    BEFORE UPDATE ON "Item"
-    FOR EACH ROW
-    EXECUTE PROCEDURE before_item_update();

prisma/schema.prisma

@@ -618,8 +618,6 @@ model OldItem {
   imgproxyUrls        Json?
   cloneBornAt         DateTime?
   cloneDiedAt         DateTime?
-  uploadId            Int?
-  pollCost            Int?
   deletedAt           DateTime?
   originalItemId      Int                   @map("original_itemId")
   originalItem        Item                  @relation(fields: [originalItemId], references: [id], onDelete: Cascade)