pay difference on territory switch

Author: Soxasora

api/paidAction/itemUpdate.js

@@ -12,12 +12,20 @@ export const paymentMethods = [
   PAID_ACTION_PAYMENT_METHODS.PESSIMISTIC
 ]
 
-export async function getCost ({ id, boost = 0, uploadIds, bio }, { me, models }) {
+// TODO: cleanup
+export async function getCost ({ subName, id, boost = 0, uploadIds, bio }, { me, models }) {
   // the only reason updating items costs anything is when it has new uploads
-  // or more boost
+  // or more boost or a more expensive sub
   const old = await models.item.findUnique({ where: { id: parseInt(id) } })
   const { totalFeesMsats } = await uploadFees(uploadIds, { models, me })
-  const cost = BigInt(totalFeesMsats) + satsToMsats(boost - old.boost)
+  let cost = BigInt(totalFeesMsats) + satsToMsats(boost - old.boost)
+  if (old.subName !== subName) {
+    const oldSub = await models.sub.findUnique({ where: { name: old.subName } })
+    const newSub = await models.sub.findUnique({ where: { name: subName } })
+    const oldCost = oldSub?.baseCost ?? 0
+    const newCost = newSub?.baseCost ?? 0
+    cost += satsToMsats(Math.max(0, newCost - oldCost))
+  }
 
   if (cost > 0 && old.invoiceActionState && old.invoiceActionState !== 'PAID') {
     throw new Error('creation invoice not paid')

api/resolvers/item.js

@@ -1479,13 +1479,14 @@ export const updateItem = async (parent, { sub: subName, forward, hash, hmac, ..
     throw new GqlInputError('item does not belong to you')
   }
 
-  const differentSub = subName && old.subName !== subName
-  if (differentSub) {
-    const sub = await models.sub.findUnique({ where: { name: subName } })
-    if (sub.baseCost > old.sub.baseCost) {
-      throw new GqlInputError('cannot change to a more expensive sub')
-    }
-  }
+  // TODO: cleanup
+  // const differentSub = subName && old.subName !== subName
+  // if (differentSub) {
+  //   const sub = await models.sub.findUnique({ where: { name: subName } })
+  //   if (sub.baseCost > old.sub.baseCost) {
+  //     // throw new GqlInputError('cannot change to a more expensive sub')
+  //   }
+  // }
 
   // in case they lied about their existing boost
   await validateSchema(advSchema, { boost: item.boost }, { models, me, existingBoost: old.boost })

components/item-history.js

@@ -2,7 +2,7 @@ import { timeSince } from '@/lib/time'
 import styles from './item.module.css'
 import Text from './text'
 import { Dropdown } from 'react-bootstrap'
-import { useRouter } from 'next/router'
+// import { useRouter } from 'next/router'
 import { useShowModal } from './modal'
 
 export function OldItem ({ version }) {
@@ -19,8 +19,9 @@ export function OldItem ({ version }) {
   )
 }
 
+// TODO: cleanup
 export default function HistoryDropdown ({ item }) {
-  const router = useRouter()
+  // const router = useRouter()
   const showModal = useShowModal()
 
   const lastEdited = new Date(item.oldVersions[0].cloneDiedAt)

pages/items/[id]/edit.js

@@ -7,26 +7,49 @@ import JobForm from '@/components/job-form'
 import { PollForm } from '@/components/poll-form'
 import { BountyForm } from '@/components/bounty-form'
 import { useState } from 'react'
-import { useQuery } from '@apollo/client'
+import { gql, useQuery } from '@apollo/client'
 import { useRouter } from 'next/router'
 import PageLoading from '@/components/page-loading'
-import { FeeButtonProvider } from '@/components/fee-button'
+import { FeeButtonProvider, postCommentBaseLineItems } from '@/components/fee-button'
 import SubSelect from '@/components/sub-select'
 import useCanShadowEdit from '@/components/use-can-edit'
+import { useMe } from '@/components/me'
 
 export const getServerSideProps = getGetServerSideProps({
   query: ITEM,
   notFound: data => !data.item
 })
 
+// TODO: cleanup
+const SUB_QUERY = gql`
+  query Sub($name: String!) {
+    sub(name: $name) {
+      name
+      baseCost
+    }
+  }
+`
+
 export default function PostEdit ({ ssrData }) {
+  const { me } = useMe()
   const router = useRouter()
   const { data } = useQuery(ITEM, { variables: { id: router.query.id } })
   if (!data && !ssrData) return <PageLoading />
 
   const { item } = data || ssrData
   const [sub, setSub] = useState(item.subName)
 
+  // TODO: cleanup
+  const { data: oldSubData } = useQuery(SUB_QUERY, {
+    variables: { name: item.subName },
+    skip: !item.subName
+  })
+
+  const { data: newSubData } = useQuery(SUB_QUERY, {
+    variables: { name: sub },
+    skip: !sub
+  })
+
   const [,, shadowEditThreshold] = useCanShadowEdit(item)
 
   let FormType = DiscussionForm
@@ -45,20 +68,26 @@ export default function PostEdit ({ ssrData }) {
     itemType = 'BOUNTY'
   }
 
-  const existingBoostLineItem = item.boost
-    ? {
-        existingBoost: {
-          label: 'old boost',
-          term: `- ${item.boost}`,
-          op: '-',
-          modifier: cost => cost - item.boost
+  function editLineItems (oldSub, newSub) {
+    const existingBoostLineItem = item.boost
+      ? {
+          existingBoost: {
+            label: 'old boost',
+            term: `- ${item.boost}`,
+            op: '-',
+            modifier: cost => cost - item.boost
+          }
         }
-      }
-    : undefined
+      : undefined
+    return {
+      ...(item.subName !== newSub?.name ? postCommentBaseLineItems({ baseCost: Math.max(0, newSub?.baseCost - oldSub?.baseCost), me: !!me }) : undefined),
+      ...existingBoostLineItem
+    }
+  }
 
   return (
     <CenterLayout sub={sub}>
-      <FeeButtonProvider baseLineItems={existingBoostLineItem}>
+      <FeeButtonProvider baseLineItems={editLineItems(oldSubData?.sub, newSubData?.sub)}>
         <FormType item={item} shadowEditThreshold={shadowEditThreshold}>
           {!item.isJob &&
             <SubSelect