Store invoiceId with wallet logs

Author: ekzyis

Diff for: api/resolvers/wallet.js

@@ -5,7 +5,7 @@ import {
 import crypto, { timingSafeEqual } from 'crypto'
 import { decodeCursor, LIMIT, nextCursorEncoded } from '@/lib/cursor'
 import { SELECT, itemQueryWithMeta } from './item'
-import { formatMsats, msatsToSats, msatsToSatsDecimal, satsToMsats } from '@/lib/format'
+import { msatsToSats, msatsToSatsDecimal, satsToMsats } from '@/lib/format'
 import {
   USER_ID, INVOICE_RETENTION_DAYS,
   PAID_ACTION_PAYMENT_METHODS,
@@ -764,29 +764,13 @@ export const walletLogger = ({ wallet, models }) => {
   // server implementation of wallet logger interface on client
   const log = (level) => async (message, context = {}) => {
     try {
-      if (context?.bolt11) {
-        // automatically populate context from bolt11 to avoid duplicating this code
-        const decoded = await parsePaymentRequest({ request: context.bolt11 })
-        context = {
-          ...context,
-          amount: formatMsats(decoded.mtokens),
-          payment_hash: decoded.id,
-          created_at: decoded.created_at,
-          expires_at: decoded.expires_at,
-          description: decoded.description,
-          // payments should affect wallet status
-          status: true
-        }
-      }
-      context.recv = true
-
       await models.walletLog.create({
         data: {
           userId: wallet.userId,
           wallet: wallet.type,
           level,
           message,
-          context
+          ...context
         }
       })
     } catch (err) {

Diff for: prisma/migrations/20250118192921_normalized_wallet_logs/migration.sql

@@ -0,0 +1,5 @@
+-- AlterTable
+ALTER TABLE "WalletLog" ADD COLUMN     "invoiceId" INTEGER;
+
+-- AddForeignKey
+ALTER TABLE "WalletLog" ADD CONSTRAINT "WalletLog_invoiceId_fkey" FOREIGN KEY ("invoiceId") REFERENCES "Invoice"("id") ON DELETE SET NULL ON UPDATE CASCADE;

Diff for: prisma/schema.prisma

@@ -255,6 +255,8 @@ model WalletLog {
   wallet    WalletType
   level     LogLevel
   message   String
+  invoiceId Int?
+  invoice   Invoice?   @relation(fields: [invoiceId], references: [id])
   context   Json?      @db.JsonB
 
   @@index([userId, createdAt])
@@ -952,6 +954,7 @@ model Invoice {
   Upload             Upload[]
   PollVote           PollVote[]
   PollBlindVote      PollBlindVote[]
+  WalletLog          WalletLog[]
 
   @@index([createdAt], map: "Invoice.created_at_index")
   @@index([userId], map: "Invoice.userId_index")

Diff for: wallets/server.js

@@ -14,7 +14,7 @@ import * as webln from '@/wallets/webln'
 import { walletLogger } from '@/api/resolvers/wallet'
 import walletDefs from '@/wallets/server'
 import { parsePaymentRequest } from 'ln-service'
-import { toPositiveBigInt, toPositiveNumber, formatMsats, formatSats, msatsToSats } from '@/lib/format'
+import { toPositiveBigInt, toPositiveNumber, formatSats, msatsToSats } from '@/lib/format'
 import { PAID_ACTION_TERMINAL_STATES, WALLET_CREATE_INVOICE_TIMEOUT_MS } from '@/lib/constants'
 import { timeoutSignal, withTimeout } from '@/lib/time'
 import { canReceive } from './common'
@@ -38,11 +38,7 @@ export async function * createUserInvoice (userId, { msats, description, descrip
     const logger = walletLogger({ wallet, models })
 
     try {
-      logger.info(
-        `↙ incoming payment: ${formatSats(msatsToSats(msats))}`,
-        {
-          amount: formatMsats(msats)
-        })
+      logger.info(`↙ incoming payment: ${formatSats(msatsToSats(msats))}`)
 
       let invoice
       try {

Diff for: worker/autowithdraw.js

@@ -53,7 +53,8 @@ export async function autoWithdraw ({ data: { id }, models, lnd }) {
         { me: { id }, models, lnd, wallet, logger })
     } catch (err) {
       console.error('failed to create autowithdrawal:', err)
-      logger?.error('incoming payment failed: ' + err.message, { bolt11: invoice })
+      // TODO: this won't work since invoice is bolt11 string
+      logger?.error('incoming payment failed: ' + err.message, { invoiceId: invoice.id })
     }
   }
 

Diff for: worker/paidAction.js

@@ -2,7 +2,7 @@ import { getPaymentFailureStatus, hodlInvoiceCltvDetails, getPaymentOrNotSent }
 import { paidActions } from '@/api/paidAction'
 import { walletLogger } from '@/api/resolvers/wallet'
 import { LND_PATHFINDING_TIME_PREF_PPM, LND_PATHFINDING_TIMEOUT_MS, PAID_ACTION_TERMINAL_STATES } from '@/lib/constants'
-import { formatMsats, formatSats, msatsToSats, toPositiveNumber } from '@/lib/format'
+import { formatSats, msatsToSats, toPositiveNumber } from '@/lib/format'
 import { datePivot } from '@/lib/time'
 import { Prisma } from '@prisma/client'
 import {
@@ -317,18 +317,12 @@ export async function paidActionForwarded ({ data: { invoiceId, withdrawal, ...a
   }, { models, lnd, boss })
 
   if (transitionedInvoice) {
-    const { bolt11, msatsPaid } = transitionedInvoice.invoiceForward.withdrawl
+    const { msatsPaid } = transitionedInvoice.invoiceForward.withdrawl
 
     const logger = walletLogger({ wallet: transitionedInvoice.invoiceForward.wallet, models })
-    logger.ok(
-      `↙ payment received: ${formatSats(msatsToSats(Number(msatsPaid)))}`,
-      {
-        bolt11,
-        preimage: transitionedInvoice.preimage
-        // we could show the outgoing fee that we paid from the incoming amount to the receiver
-        // but we don't since it might look like the receiver paid the fee but that's not the case.
-        // fee: formatMsats(msatsFeePaid)
-      })
+    logger.ok(`↙ payment received: ${formatSats(msatsToSats(Number(msatsPaid)))}`, {
+      invoiceId: transitionedInvoice.id
+    })
   }
 
   return transitionedInvoice
@@ -376,13 +370,10 @@ export async function paidActionFailedForward ({ data: { invoiceId, withdrawal:
   }, { models, lnd, boss })
 
   if (transitionedInvoice) {
-    const { bolt11, msatsFeePaying } = transitionedInvoice.invoiceForward.withdrawl
     const logger = walletLogger({ wallet: transitionedInvoice.invoiceForward.wallet, models })
-    logger.warn(
-      `incoming payment failed: ${message}`, {
-        bolt11,
-        max_fee: formatMsats(msatsFeePaying)
-      })
+    logger.warn(`incoming payment failed: ${message}`, {
+      invoiceId: transitionedInvoice.id
+    })
   }
 
   return transitionedInvoice
@@ -446,7 +437,9 @@ export async function paidActionCanceling ({ data: { invoiceId, ...args }, model
       const { wallet, bolt11 } = transitionedInvoice.invoiceForward
       const logger = walletLogger({ wallet, models })
       const decoded = await parsePaymentRequest({ request: bolt11 })
-      logger.info(`invoice for ${formatSats(msatsToSats(decoded.mtokens))} canceled by payer`, { bolt11 })
+      logger.info(`invoice for ${formatSats(msatsToSats(decoded.mtokens))} canceled by payer`, {
+        invoiceId: transitionedInvoice.id
+      })
     }
   }
 

Diff for: worker/payingAction.js

@@ -1,6 +1,6 @@
 import { getPaymentFailureStatus, getPaymentOrNotSent } from '@/api/lnd'
 import { walletLogger } from '@/api/resolvers/wallet'
-import { formatMsats, formatSats, msatsToSats, toPositiveBigInt } from '@/lib/format'
+import { formatSats, msatsToSats, toPositiveBigInt } from '@/lib/format'
 import { datePivot } from '@/lib/time'
 import { notifyWithdrawal } from '@/lib/webPush'
 import { Prisma } from '@prisma/client'
@@ -124,13 +124,10 @@ export async function payingActionConfirmed ({ data: args, models, lnd, boss })
     await notifyWithdrawal(transitionedWithdrawal)
 
     const logger = walletLogger({ models, wallet: transitionedWithdrawal.wallet })
-    logger?.ok(
-      `↙ payment received: ${formatSats(msatsToSats(transitionedWithdrawal.msatsPaid))}`,
-      {
-        bolt11: transitionedWithdrawal.bolt11,
-        preimage: transitionedWithdrawal.preimage,
-        fee: formatMsats(transitionedWithdrawal.msatsFeePaid)
-      })
+    logger?.ok(`↙ payment received: ${formatSats(msatsToSats(transitionedWithdrawal.msatsPaid))}`, {
+      // TODO: test this
+      invoiceId: transitionedWithdrawal.invoiceForward.invoice.id
+    })
   }
 }
 
@@ -166,11 +163,9 @@ export async function payingActionFailed ({ data: args, models, lnd, boss }) {
 
   if (transitionedWithdrawal) {
     const logger = walletLogger({ models, wallet: transitionedWithdrawal.wallet })
-    logger?.error(
-      `incoming payment failed: ${message}`,
-      {
-        bolt11: transitionedWithdrawal.bolt11,
-        max_fee: formatMsats(transitionedWithdrawal.msatsFeePaying)
-      })
+    logger?.error(`incoming payment failed: ${message}`, {
+      // TODO: test this
+      invoiceId: transitionedWithdrawal.invoiceForward.invoice.id
+    })
   }
 }