Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI and tests failing on external contributor PRs #82

Open
DavidMazarro opened this issue Mar 14, 2025 · 0 comments
Open

CI and tests failing on external contributor PRs #82

DavidMazarro opened this issue Mar 14, 2025 · 0 comments
Labels
ci Changes to the CI workflow good first issue Good for newcomers

Comments

@DavidMazarro
Copy link
Member

On incoming PRs from forks, the tests fail:

  src/Data/Yaml/Config.hs:215:19: 
  1) Rollbar.Yesod.rollbarYesodMiddlewareWith, when there is an error, triggers a call to Rollbar
       uncaught exception: ErrorCall
       Could not convert to expected type: Error in $.token: parsing Token failed, expected String, but encountered Null
       CallStack (from HasCallStack):
         error, called at src/Data/Yaml/Config.hs:215:19 in yaml-0.11.11.2-72b012f81738f9aa8a0375a02116a9c2de7469091d3d770581aea04b4133eac8:Data.Yaml.Config

We found out a year ago or so that this is caused by an intentional limitation on GitHub Actions runners. Runners forbid using secrets in the CI of external PRs for security reasons (to avoid leakage and mishandling). Since we rely on a Rollbar token to run E2E tests, this means that the tests are failing.

We want to keep these E2E tests, so one potential solution would be:

  • Disabling the CI in external PRs coming from forks.
  • Asking external contributors to provide proof of tests passing when asking for review, or run the tests ourselves locally for external contributions, to ensure that they pass.
@DavidMazarro DavidMazarro added ci Changes to the CI workflow good first issue Good for newcomers labels Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to the CI workflow good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant