Apply suggestions from code review

NickLarsenNZ · web-flow · commit c85680109ed7 · 2025-10-27T19:34:28.000+01:00
diff --git a/kube-core/src/schema/transform_any_of.rs b/kube-core/src/schema/transform_any_of.rs
@@ -214,6 +214,5 @@ pub(crate) fn hoist_any_of_subschema_with_a_nullable_variant(kube_schema: &mut S
     *kube_schema = to_hoist;
 
     // Set the schema to nullable (as we know we matched the null variant earlier)
-    // TODO (@NickLarsenNZ): Do we need to insert `nullable` into `other` too?
     kube_schema.extensions.insert("nullable".to_owned(), true.into());
 }
diff --git a/kube-derive/tests/crd_mixed_enum_test.rs b/kube-derive/tests/crd_mixed_enum_test.rs
@@ -269,8 +269,6 @@ fn valid_enum_4() {
 fn invalid_enum_5() {
     InvalidEnum5::crd();
 }
-
-
 #[test]
 fn valid_enum_6() {
     assert_json_eq!(

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,5 @@ pub(crate) fn hoist_any_of_subschema_with_a_nullable_variant(kube_schema: &mut S`
`214`	`214`	`*kube_schema = to_hoist;`
`215`	`215`
`216`	`216`	`// Set the schema to nullable (as we know we matched the null variant earlier)`
`217`		- // TODO (@NickLarsenNZ): Do we need to insert `nullable` into `other` too?
`218`	`217`	`kube_schema.extensions.insert("nullable".to_owned(), true.into());`
`219`	`218`	`}`