|
1 | 1 | import { test, expect, type Page } from '../support/fixtures.js'; |
2 | | -import { hasGarageCredentials, requireGarageCredentials } from '../support/garage.js'; |
| 2 | +import { |
| 3 | + createGarageBucketCredentials, |
| 4 | + hasGarageAdmin, |
| 5 | + hasGarageCredentials, |
| 6 | + requireGarageCredentials |
| 7 | +} from '../support/garage.js'; |
3 | 8 | import { connectToStorage, openConnectForm } from './helpers.js'; |
4 | 9 | import { waitForHydration } from '../support/helpers.js'; |
5 | 10 |
|
@@ -321,3 +326,162 @@ test.describe('Storage — Connections management', () => { |
321 | 326 | await expect(page).toHaveURL('/settings/connections'); |
322 | 327 | }); |
323 | 328 | }); |
| 329 | + |
| 330 | +test.describe('Storage — Connection edit sidebar', () => { |
| 331 | + test.use({ locale: 'en-US' }); |
| 332 | + |
| 333 | + test.beforeEach(() => { |
| 334 | + test.skip( |
| 335 | + !hasGarageCredentials() || !hasGarageAdmin(), |
| 336 | + 'Skipped: requires a running Garage instance with admin access' |
| 337 | + ); |
| 338 | + }); |
| 339 | + |
| 340 | + /** |
| 341 | + * Saves two connections that differ in their access key, then opens the edit page of the most |
| 342 | + * recent one from the saved connections sidebar, which stays filled when navigated from there. |
| 343 | + * Returns the access keys in sidebar order. |
| 344 | + */ |
| 345 | + async function openEditWithTwoConnections(page: Page): Promise<[string, string]> { |
| 346 | + const base = requireGarageCredentials(); |
| 347 | + const second = await createGarageBucketCredentials(base, { |
| 348 | + bucketName: 'e2e-connection-edit-sidebar', |
| 349 | + keyName: 'e2e-connection-edit-sidebar', |
| 350 | + permissions: { owner: false, read: true, write: false } |
| 351 | + }); |
| 352 | + await connectToStorage(page, base); |
| 353 | + await connectToStorage(page, second, { clearSaved: false }); |
| 354 | + |
| 355 | + await page.getByRole('button', { name: 'Disconnect' }).click(); |
| 356 | + await page.getByRole('dialog').getByRole('button', { name: 'Disconnect' }).click(); |
| 357 | + await expect(page.getByRole('heading', { name: 'Connect to storage' })).toBeVisible(); |
| 358 | + const savedList = page.getByRole('list', { name: 'Saved connections' }); |
| 359 | + await expect(savedList.getByRole('listitem')).toHaveCount(2); |
| 360 | + await savedList.getByRole('button', { name: 'More options' }).first().click({ force: true }); |
| 361 | + await page.getByRole('menuitem', { name: 'Edit', exact: true }).click(); |
| 362 | + await waitForHydration(page); |
| 363 | + await expect(page.getByRole('heading', { name: 'Edit connection' })).toBeVisible(); |
| 364 | + |
| 365 | + // Most recently saved first. |
| 366 | + return [second.accessKeyId, base.accessKeyId]; |
| 367 | + } |
| 368 | + |
| 369 | + function sidebarConnection(page: Page, index: number) { |
| 370 | + return page |
| 371 | + .getByRole('list', { name: 'Saved connections' }) |
| 372 | + .getByRole('listitem') |
| 373 | + .nth(index) |
| 374 | + .getByRole('button') |
| 375 | + .first(); |
| 376 | + } |
| 377 | + |
| 378 | + async function deleteFromSidebar(page: Page, index: number) { |
| 379 | + await page |
| 380 | + .getByRole('list', { name: 'Saved connections' }) |
| 381 | + .getByRole('button', { name: 'More options' }) |
| 382 | + .nth(index) |
| 383 | + .click({ force: true }); |
| 384 | + await page.getByRole('menuitem', { name: 'Delete', exact: true }).click(); |
| 385 | + await page.getByRole('dialog').getByRole('button', { name: 'Delete', exact: true }).click(); |
| 386 | + } |
| 387 | + |
| 388 | + test('switching connections loads the other connection without asking', async ({ page }) => { |
| 389 | + const [firstKey, secondKey] = await openEditWithTwoConnections(page); |
| 390 | + await expect(page.getByLabel('Access key')).toHaveValue(firstKey); |
| 391 | + const firstUrl = page.url(); |
| 392 | + |
| 393 | + await sidebarConnection(page, 1).click(); |
| 394 | + |
| 395 | + await expect(page).not.toHaveURL(firstUrl); |
| 396 | + await expect(page.getByLabel('Access key')).toHaveValue(secondKey); |
| 397 | + await expect(page.getByRole('dialog')).toHaveCount(0); |
| 398 | + |
| 399 | + // The switch must not leave the form tainted. |
| 400 | + await page.getByRole('link', { name: '← Manage connections' }).click(); |
| 401 | + await expect(page).toHaveURL('/settings/connections'); |
| 402 | + await expect(page.getByRole('dialog')).toHaveCount(0); |
| 403 | + }); |
| 404 | + |
| 405 | + test('switching connections with unsaved changes asks first', async ({ page }) => { |
| 406 | + await openEditWithTwoConnections(page); |
| 407 | + const firstUrl = page.url(); |
| 408 | + |
| 409 | + await page.getByLabel('Connection name').fill('Changed name'); |
| 410 | + await sidebarConnection(page, 1).click(); |
| 411 | + |
| 412 | + await expect(page.getByRole('heading', { name: 'Unsaved changes' })).toBeVisible(); |
| 413 | + await page.getByRole('dialog').getByRole('button', { name: 'Stay on page' }).click(); |
| 414 | + await expect(page).toHaveURL(firstUrl); |
| 415 | + await expect(page.getByLabel('Connection name')).toHaveValue('Changed name'); |
| 416 | + }); |
| 417 | + |
| 418 | + test('sidebar delete with unsaved changes asks in the app before deleting', async ({ page }) => { |
| 419 | + await openEditWithTwoConnections(page); |
| 420 | + let deleteRequests = 0; |
| 421 | + let nativeDialogs = 0; |
| 422 | + page.on('request', (request) => { |
| 423 | + if (request.url().endsWith('?/deleteConnection')) deleteRequests++; |
| 424 | + }); |
| 425 | + page.on('dialog', (dialog) => { |
| 426 | + nativeDialogs++; |
| 427 | + void dialog.dismiss(); |
| 428 | + }); |
| 429 | + |
| 430 | + await page.getByLabel('Connection name').fill('Changed name'); |
| 431 | + await deleteFromSidebar(page, 1); |
| 432 | + |
| 433 | + await expect(page.getByRole('heading', { name: 'Unsaved changes' })).toBeVisible(); |
| 434 | + await page.getByRole('button', { name: 'Stay on page' }).click(); |
| 435 | + await expect(page.getByRole('heading', { name: 'Unsaved changes' })).toBeHidden(); |
| 436 | + await expect(page).toHaveURL(/\/edit$/); |
| 437 | + expect(deleteRequests).toBe(0); |
| 438 | + |
| 439 | + await deleteFromSidebar(page, 1); |
| 440 | + await page.getByRole('button', { name: 'Leave' }).click(); |
| 441 | + |
| 442 | + await expect(page).toHaveURL('/settings/connections'); |
| 443 | + await expect(page.locator('table tbody tr')).toHaveCount(1); |
| 444 | + expect(deleteRequests).toBe(1); |
| 445 | + expect(nativeDialogs).toBe(0); |
| 446 | + }); |
| 447 | + |
| 448 | + test('sidebar delete without changes deletes without asking', async ({ page }) => { |
| 449 | + await openEditWithTwoConnections(page); |
| 450 | + |
| 451 | + await deleteFromSidebar(page, 1); |
| 452 | + |
| 453 | + await expect(page).toHaveURL('/settings/connections'); |
| 454 | + await expect(page.getByRole('heading', { name: 'Unsaved changes' })).toHaveCount(0); |
| 455 | + await expect(page.locator('table tbody tr')).toHaveCount(1); |
| 456 | + |
| 457 | + // The sidebar on the next edit page no longer lists the deleted connection. |
| 458 | + await openFirstConnectionEditPage(page); |
| 459 | + await expect( |
| 460 | + page.getByRole('list', { name: 'Saved connections' }).getByRole('listitem') |
| 461 | + ).toHaveCount(1); |
| 462 | + }); |
| 463 | + |
| 464 | + test('a failed sidebar delete shows the error and keeps the unsaved changes', async ({ |
| 465 | + page |
| 466 | + }) => { |
| 467 | + await openEditWithTwoConnections(page); |
| 468 | + // An invalid ID makes the action fail. |
| 469 | + await page.route(/\?\/deleteConnection$/, (route) => |
| 470 | + route.continue({ postData: 'connectionId=not-a-uuid' }) |
| 471 | + ); |
| 472 | + |
| 473 | + await page.getByLabel('Connection name').fill('Changed name'); |
| 474 | + await deleteFromSidebar(page, 1); |
| 475 | + await page.getByRole('button', { name: 'Leave' }).click(); |
| 476 | + |
| 477 | + await expect( |
| 478 | + page.getByRole('alert').filter({ hasText: 'Connection not found.' }) |
| 479 | + ).toBeVisible(); |
| 480 | + await expect(page).toHaveURL(/\/edit$/); |
| 481 | + await expect(page.getByLabel('Connection name')).toHaveValue('Changed name'); |
| 482 | + |
| 483 | + // The changes are still guarded. |
| 484 | + await page.getByRole('link', { name: '← Manage connections' }).click(); |
| 485 | + await expect(page.getByRole('heading', { name: 'Unsaved changes' })).toBeVisible(); |
| 486 | + }); |
| 487 | +}); |
0 commit comments