Skip to content

Commit 243189c

Browse files
committed
enhance kanji details modal: improve accessibility with aria attributes and update tabindex
1 parent a7578e0 commit 243189c

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src-tauri/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ use std::path::PathBuf;
44
use std::fs;
55
use std::collections::HashMap;
66
use tauri::{AppHandle, Manager};
7-
use chrono::{DateTime, Utc, Duration, NaiveDateTime, NaiveDate};
87

98
#[derive(Serialize)]
109
struct Kanji {

src/routes/kanji_view/+page.svelte

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -428,11 +428,12 @@
428428

429429
<!-- Kanji Details Modal -->
430430
{#if modalOpen && selectedKanji}
431-
<div class="modal-overlay" on:click={closeModal} on:keydown={handleKeydown} tabindex="0" role="dialog" aria-modal="true">
431+
<!-- svelte-ignore a11y-no-noninteractive-element-interactions -->
432+
<div class="modal-overlay" on:click={closeModal} on:keydown={handleKeydown} tabindex="-1" role="dialog" aria-modal="true" aria-labelledby="modal-title">
432433
<div class="modal-content" on:click|stopPropagation on:keydown|stopPropagation role="document">
433434
<div class="modal-header">
434-
<h2>Kanji Details</h2>
435-
<button class="close-button" on:click={closeModal}>×</button>
435+
<h2 id="modal-title">Kanji Details</h2>
436+
<button class="close-button" on:click={closeModal} aria-label="Close modal">×</button>
436437
</div>
437438

438439
<div class="modal-body">

0 commit comments

Comments
 (0)