Merge pull request #610 from srvrco/release_231

Release v2.31

Author: timkimber

Diff for: getssl

@@ -241,12 +241,12 @@
 # 2020-10-02 Various fixes to get_auth_dns and changes to support unit tests (#308)
 # 2020-10-04 Add CHECK_PUBLIC_DNS_SERVER to check the DNS challenge has been updated there
 # 2020-10-13 Bugfix: strip comments in drill/dig output (mhameed)
-# 2020-11-18 Wildcard support (#347)(#400)
+# 2020-11-18 Wildcard support (#347)(#400)(2.31)
 # ----------------------------------------------------------------------------------------
 
 PROGNAME=${0##*/}
 PROGDIR="$(cd "$(dirname "$0")" || exit; pwd -P;)"
-VERSION="2.30"
+VERSION="2.31"
 
 # defaults
 ACCOUNT_KEY_LENGTH=4096
@@ -1255,13 +1255,11 @@ done # end of ... loop through domains for cert ( from SANS list)
 
 get_auth_dns() { # get the authoritative dns server for a domain (sets primary_ns )
   orig_gad_d="$1" # domain name
-  gad_s="$PUBLIC_DNS_SERVER" # start with PUBLIC_DNS_SERVER
-  if [[ -n "$gad_s" ]]; then
-    gad_s="@$gad_s"
-  fi
+  orig_gad_s="$PUBLIC_DNS_SERVER" # start with PUBLIC_DNS_SERVER
+  gad_d="$orig_gad_d"
+  gad_s="$orig_gad_s"
 
   if [[ "$os" == "cygwin" ]]; then
-    gad_d="$orig_gad_d"
     # shellcheck disable=SC2086
     all_auth_dns_servers=$(nslookup -type=soa "${d}" ${PUBLIC_DNS_SERVER} 2>/dev/null \
                           | grep "primary name server" \
@@ -1278,7 +1276,10 @@ get_auth_dns() { # get the authoritative dns server for a domain (sets primary_n
   fi
 
   if [[ -n "$HAS_DIG_OR_DRILL" ]]; then
-    gad_d="$orig_gad_d"
+    if [[ -n "$gad_s" ]]; then
+      gad_s="@$gad_s"
+    fi
+
     # Use SOA +trace to find the name server
     if [[ $_TEST_SKIP_SOA_CALL == 0 ]]; then
       if [[ "$HAS_DIG_OR_DRILL" == "dig" ]]; then
@@ -1350,6 +1351,9 @@ get_auth_dns() { # get the authoritative dns server for a domain (sets primary_n
     fi
   fi
 
+  # Remove leading '@' if we tried using dig/drill
+  gad_s="$orig_gad_s"
+
   if [[ "$HAS_HOST" == "true" ]]; then
     gad_d="$orig_gad_d"
     debug Using "host -t NS" to find primary name server for "$gad_d"

Diff for: test/test-config/getssl-staging-dns01.cfg

@@ -6,12 +6,12 @@ VALIDATE_VIA_DNS=true
 DNS_ADD_COMMAND="/getssl/dns_scripts/dns_add_duckdns"
 DNS_DEL_COMMAND="/getssl/dns_scripts/dns_del_duckdns"
 PUBLIC_DNS_SERVER=1.1.1.1
-CHECK_ALL_AUTH_DNS="false"
+CHECK_ALL_AUTH_DNS="true"
+CHECK_PUBLIC_DNS_SERVER="true"
 DNS_EXTRA_WAIT=120
 
-# Speed up the test by reducing the number or retries and the wait between retries.
-DNS_WAIT=2
-DNS_WAIT_COUNT=11
+# Speed up the test by reducing the number or retries and retrying DNS_ADD after 10 failures
+DNS_WAIT_COUNT=20
 DNS_WAIT_RETRY_ADD="true"
 
 ACCOUNT_KEY_TYPE="rsa"