Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt option could be deprecated #55

Closed
d47081 opened this issue Dec 23, 2024 · 1 comment
Closed

Salt option could be deprecated #55

d47081 opened this issue Dec 23, 2024 · 1 comment

Comments

@d47081
Copy link

d47081 commented Dec 23, 2024

Hi and thanks for your work!

I found this crate requires the salt argument in hash_encoded example,
but it usually marked as deprecated everywhere, at least in same PHP method:

https://www.php.net/manual/en/function.password-hash.php

Warning

The salt option is deprecated. It is now preferred to simply use the salt that is generated by default. As of PHP 8.0.0, an explicitly given salt is ignored.

What do you think about?

@mrijkeboer
Copy link
Member

Hi @d47081,

Thanks for opening this issue. This library is based on the original (reference) Argon2 implementation. This original implementation also requires the salt argument in hash_encoded. Since this behavior is present in the reference implementation I'm not in favor of changing this.

@d47081 d47081 closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants