Skip to content

Commit 61dd1fb

Browse files
committed
Do not handle merges in --devs
Signed-off-by: Vadim Markovtsev <[email protected]>
1 parent 0a3e606 commit 61dd1fb

File tree

2 files changed

+29
-3
lines changed

2 files changed

+29
-3
lines changed

leaves/devs.go

+5
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,11 @@ func (devs *DevsAnalysis) Consume(deps map[string]interface{}) (map[string]inter
158158
devsDay[author] = dd
159159
}
160160
dd.Commits++
161+
if deps[core.DependencyIsMerge].(bool) {
162+
// we ignore merge commit diffs
163+
// TODO(vmarkovtsev): handle them
164+
return nil, nil
165+
}
161166
cache := deps[items.DependencyBlobCache].(map[plumbing.Hash]*items.CachedBlob)
162167
fileDiffs := deps[items.DependencyFileDiff].(map[string]items.FileDiffData)
163168
langs := deps[items.DependencyLanguages].(map[plumbing.Hash]string)

leaves/devs_test.go

+24-3
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,23 @@ func TestDevsConsumeFinalize(t *testing.T) {
156156
assert.Equal(t, dev.Languages["Go"].Removed, 9)
157157
assert.Equal(t, dev.Languages["Go"].Changed, 67)
158158

159+
deps[core.DependencyIsMerge] = true
160+
result, err = devs.Consume(deps)
161+
assert.Nil(t, result)
162+
assert.Nil(t, err)
163+
assert.Len(t, devs.days, 1)
164+
day = devs.days[0]
165+
assert.Len(t, day, 1)
166+
dev = day[0]
167+
assert.Equal(t, dev.Commits, 2)
168+
assert.Equal(t, dev.Added, 847)
169+
assert.Equal(t, dev.Removed, 9)
170+
assert.Equal(t, dev.Changed, 67)
171+
assert.Equal(t, dev.Languages["Go"].Added, 847)
172+
assert.Equal(t, dev.Languages["Go"].Removed, 9)
173+
assert.Equal(t, dev.Languages["Go"].Changed, 67)
174+
175+
deps[core.DependencyIsMerge] = false
159176
deps[identity.DependencyAuthor] = 1
160177
result, err = devs.Consume(deps)
161178
assert.Nil(t, result)
@@ -165,7 +182,11 @@ func TestDevsConsumeFinalize(t *testing.T) {
165182
assert.Len(t, day, 2)
166183
for i := 0; i < 2; i++ {
167184
dev = day[i]
168-
assert.Equal(t, dev.Commits, 1)
185+
if i == 0 {
186+
assert.Equal(t, dev.Commits, 2)
187+
} else {
188+
assert.Equal(t, dev.Commits, 1)
189+
}
169190
assert.Equal(t, dev.Added, 847)
170191
assert.Equal(t, dev.Removed, 9)
171192
assert.Equal(t, dev.Changed, 67)
@@ -181,7 +202,7 @@ func TestDevsConsumeFinalize(t *testing.T) {
181202
day = devs.days[0]
182203
assert.Len(t, day, 2)
183204
dev = day[0]
184-
assert.Equal(t, dev.Commits, 1)
205+
assert.Equal(t, dev.Commits, 2)
185206
assert.Equal(t, dev.Added, 847)
186207
assert.Equal(t, dev.Removed, 9)
187208
assert.Equal(t, dev.Changed, 67)
@@ -205,7 +226,7 @@ func TestDevsConsumeFinalize(t *testing.T) {
205226
day = devs.days[0]
206227
assert.Len(t, day, 2)
207228
dev = day[0]
208-
assert.Equal(t, dev.Commits, 1)
229+
assert.Equal(t, dev.Commits, 2)
209230
assert.Equal(t, dev.Added, 847)
210231
assert.Equal(t, dev.Removed, 9)
211232
assert.Equal(t, dev.Changed, 67)

0 commit comments

Comments
 (0)