Skip to content

Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lachaib opened this issue Mar 19, 2025 · 2 comments
Closed

Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql #1626

lachaib opened this issue Mar 19, 2025 · 2 comments
Labels
op directives postgresql use case not quite a feature and not quite a bug, something we just didn't think of

Comments

@lachaib
Copy link
Contributor

lachaib commented Mar 19, 2025

Describe the use case
Add support for IF [NOT] EXISTS for ADDDROP COLUMN operations available on PostgreSQL

Databases / Backends / Drivers targeted
PostgreSQL

Example Use
The goal is to have automatically generated operations rewritable to add if_exists/if_not_exists attributes, then rendered with postgres compiler.

@writer.rewrites(ops.AddColumnOp)
def add_column(autogen_context, _revision, op: ops.AddColumnOp):
    op.if_not_exists = True

would generate following SQL

ALTER TABLE t ADD COLUMN IF NOT EXISTS c INTEGER;

Additional context
Spin-off of #524 for ADD/DROP COLUMN

Have a nice day!
@lachaib lachaib added requires triage New issue that requires categorization use case not quite a feature and not quite a bug, something we just didn't think of labels Mar 19, 2025
lachaib added a commit to lachaib/alembic that referenced this issue Mar 19, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
7456d83 
Fixes sqlalchemy#1626
@lachaib lachaib mentioned this issue Mar 19, 2025
Closed
3 tasks
@CaselIT CaselIT added postgresql op directives and removed requires triage New issue that requires categorization labels Mar 19, 2025
lachaib added a commit to lachaib/alembic that referenced this issue Mar 19, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
0a85a7f 
Fixes sqlalchemy#1626
lachaib added a commit to lachaib/alembic that referenced this issue Mar 20, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
c9a7bc2 
Fixes sqlalchemy#1626
@zzzeek zzzeek mentioned this issue Apr 24, 2025
Closed
lachaib added a commit to lachaib/alembic that referenced this issue Apr 30, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
1cd9a39 
Fixes sqlalchemy#1626
@sqla-tester
Copy link
Collaborator

Louis-Amaury Chaib has proposed a fix for this issue in the main branch:

Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5879

lachaib added a commit to lachaib/alembic that referenced this issue Apr 30, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
7702b01 
Fixes sqlalchemy#1626
lachaib added a commit to lachaib/alembic that referenced this issue May 2, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
89773d4 
Fixes sqlalchemy#1626
lachaib added a commit to lachaib/alembic that referenced this issue May 2, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
7154331 
Fixes sqlalchemy#1626
lachaib added a commit to lachaib/alembic that referenced this issue May 2, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
5391908 
Fixes sqlalchemy#1626
lachaib added a commit to lachaib/alembic that referenced this issue May 13, 2025
@lachaib
Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql
82d6319 
Fixes sqlalchemy#1626
@sqla-tester
Copy link
Collaborator

Louis-Amaury Chaib has proposed a fix for this issue in the main branch:

Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5879

sqlalchemy-bot pushed a commit that referenced this issue May 19, 2025
@zzzeek
add autogen render for drop_constraint.if_exists
92a4f5c 
I've maintained all along that #1650 and #1626 are the same thing
and should have been one big PR.   Here we complete the autogen
portion of the #1650 PR that was omitted.

Fixes: #1650
Change-Id: I0e98feca6ce9aa908f27c8bf7af036d116f93404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
op directives postgresql use case not quite a feature and not quite a bug, something we just didn't think of
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support of IF [NOT] EXISTS for ADD/DROP COLUMN in Postgresql lachaib/alembic
3 participants
@sqla-tester @CaselIT @lachaib