From 5a4b1bbfc2ee136b6ae8df766519e0ab63e0d19b Mon Sep 17 00:00:00 2001 From: topiam Date: Tue, 25 Feb 2025 10:08:10 +0800 Subject: [PATCH] Support Custom RequestMatchers for WebAuthn Signed-off-by: topiam --- .../PublicKeyCredentialRequestOptionsFilterTests.java | 2 +- .../PublicKeyCredentialCreationOptionsFilterTests.java | 4 ++-- .../registration/WebAuthnRegistrationFilterTests.java | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/web/src/test/java/org/springframework/security/web/webauthn/authentication/PublicKeyCredentialRequestOptionsFilterTests.java b/web/src/test/java/org/springframework/security/web/webauthn/authentication/PublicKeyCredentialRequestOptionsFilterTests.java index b1385d23d9..b04f107216 100644 --- a/web/src/test/java/org/springframework/security/web/webauthn/authentication/PublicKeyCredentialRequestOptionsFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/webauthn/authentication/PublicKeyCredentialRequestOptionsFilterTests.java @@ -101,7 +101,7 @@ void cleanup() { } @Test - public void doFilterWhenCustomRequestMatcherThenUses() throws Exception { + void doFilterWhenCustomRequestMatcherThenUses() throws Exception { RequestMatcher requestMatcher = mock(RequestMatcher.class); this.filter.setRequestMatcher(requestMatcher); FilterChain mock = mock(FilterChain.class); diff --git a/web/src/test/java/org/springframework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilterTests.java b/web/src/test/java/org/springframework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilterTests.java index 457916ca82..e017a93c21 100644 --- a/web/src/test/java/org/springframework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilterTests.java @@ -91,7 +91,7 @@ void clear() { } @Test - public void doFilterWhenCustomRequestMatcherThenUses() throws Exception { + void doFilterWhenCustomRequestMatcherThenUses() throws Exception { RequestMatcher requestMatcher = mock(RequestMatcher.class); this.filter.setRequestMatcher(requestMatcher); FilterChain mock = mock(FilterChain.class); @@ -100,7 +100,7 @@ public void doFilterWhenCustomRequestMatcherThenUses() throws Exception { } @Test - public void setRequestMatcherWhenNullThenIllegalArgument() { + void setRequestMatcherWhenNullThenIllegalArgument() { assertThatIllegalArgumentException().isThrownBy(() -> this.filter.setRequestMatcher(null)); } diff --git a/web/src/test/java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilterTests.java b/web/src/test/java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilterTests.java index 1a3e77d04a..9962e23289 100644 --- a/web/src/test/java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilterTests.java @@ -112,7 +112,7 @@ void setup() { } @Test - public void doFilterWhenCustomRequestRegisterCredentialMatcherThenUses() throws Exception { + void doFilterWhenCustomRequestRegisterCredentialMatcherThenUses() throws Exception { RequestMatcher requestMatcher = mock(RequestMatcher.class); this.filter.setRegisterCredentialMatcher(requestMatcher); FilterChain mock = mock(FilterChain.class); @@ -121,7 +121,7 @@ public void doFilterWhenCustomRequestRegisterCredentialMatcherThenUses() throws } @Test - public void doFilterWhenCustomRequestRemoveCredentialMatcherThenUses() throws Exception { + void doFilterWhenCustomRequestRemoveCredentialMatcherThenUses() throws Exception { RequestMatcher requestMatcher = mock(RequestMatcher.class); this.filter.setRemoveCredentialMatcher(requestMatcher); FilterChain mock = mock(FilterChain.class); @@ -130,12 +130,12 @@ public void doFilterWhenCustomRequestRemoveCredentialMatcherThenUses() throws Ex } @Test - public void setRequestRegisterCredentialWhenNullThenIllegalArgument() { + void setRequestRegisterCredentialWhenNullThenIllegalArgument() { assertThatIllegalArgumentException().isThrownBy(() -> this.filter.setRegisterCredentialMatcher(null)); } @Test - public void setRequestRemoveCredentialWhenNullThenIllegalArgument() { + void setRequestRemoveCredentialWhenNullThenIllegalArgument() { assertThatIllegalArgumentException().isThrownBy(() -> this.filter.setRemoveCredentialMatcher(null)); }